summaryrefslogtreecommitdiffstats
path: root/chrome/test/automation/automation_proxy.cc
diff options
context:
space:
mode:
authorphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-24 09:34:14 +0000
committerphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-24 09:34:14 +0000
commit4cc8eb5b72b445d6ec8ad965588f2014012947a2 (patch)
tree6dba80504dacb24991ba037397f2563aa9cf9a26 /chrome/test/automation/automation_proxy.cc
parent309d7a28aa6c938f60ac7a543ab4a73827d29562 (diff)
downloadchromium_src-4cc8eb5b72b445d6ec8ad965588f2014012947a2.zip
chromium_src-4cc8eb5b72b445d6ec8ad965588f2014012947a2.tar.gz
chromium_src-4cc8eb5b72b445d6ec8ad965588f2014012947a2.tar.bz2
Get rid of WaitForWindowCountToChange.
The function had confusing semantics, was marked to be removed, and could induce flakiness in tests which used it. WaitForWindowCountToBecome is much better replacement for it. Review URL: http://codereview.chromium.org/49007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12348 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/automation/automation_proxy.cc')
-rw-r--r--chrome/test/automation/automation_proxy.cc14
1 files changed, 0 insertions, 14 deletions
diff --git a/chrome/test/automation/automation_proxy.cc b/chrome/test/automation/automation_proxy.cc
index 35d44f8..3a8f406 100644
--- a/chrome/test/automation/automation_proxy.cc
+++ b/chrome/test/automation/automation_proxy.cc
@@ -251,20 +251,6 @@ bool AutomationProxy::GetBrowserWindowCount(int* num_windows) {
return succeeded;
}
-bool AutomationProxy::WaitForWindowCountToChange(int count, int* new_count,
- int wait_timeout) {
- const TimeTicks start = TimeTicks::Now();
- const TimeDelta timeout = TimeDelta::FromMilliseconds(wait_timeout);
- while (TimeTicks::Now() - start < timeout) {
- bool succeeded = GetBrowserWindowCount(new_count);
- if (!succeeded) return false;
- if (count != *new_count) return true;
- PlatformThread::Sleep(automation::kSleepTime);
- }
- // Window count never changed.
- return false;
-}
-
bool AutomationProxy::WaitForWindowCountToBecome(int count,
int wait_timeout) {
const TimeTicks start = TimeTicks::Now();