diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-19 17:08:12 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-19 17:08:12 +0000 |
| commit | 2ce26c438a2cd219348eefa324a64c15d1bf8cf2 (patch) | |
| tree | 8b17944db4ef181365a7a29d4c86bb96f9a29754 /chrome/test/automation/automation_proxy.h | |
| parent | 334b47007cdd108b8e0b0566bd29f952f5ad71f8 (diff) | |
| download | chromium_src-2ce26c438a2cd219348eefa324a64c15d1bf8cf2.zip chromium_src-2ce26c438a2cd219348eefa324a64c15d1bf8cf2.tar.gz chromium_src-2ce26c438a2cd219348eefa324a64c15d1bf8cf2.tar.bz2 | |
Wait properly for renderer crashes
This replaces a Sleep in automation with a wait for renderer crash. It turns out that our IPC on POSIX had one loophole that caused it not to notice very early crashes, so I also fixed that.
The problem was that when the child process died before connecting to the parent's IPC channel, the parent wouldn't notice the crash because the child end of the IPC pipe was kept open for too long. This change makes the code close the child end of the pipe right after forking the child.
This might also help with automation not noticing the browser crash during initial launch, or at least should be a good step toward fixing that problem.
BUG=38497,90489
Review URL: http://codereview.chromium.org/7870008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101760 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/automation/automation_proxy.h')
| -rw-r--r-- | chrome/test/automation/automation_proxy.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/chrome/test/automation/automation_proxy.h b/chrome/test/automation/automation_proxy.h index a41689d..0fccd90 100644 --- a/chrome/test/automation/automation_proxy.h +++ b/chrome/test/automation/automation_proxy.h @@ -222,9 +222,7 @@ class AutomationProxy : public IPC::Channel::Listener, const std::string& password) WARN_UNUSED_RESULT; #endif -#if defined(OS_POSIX) - base::file_handle_mapping_vector fds_to_map() const; -#endif + IPC::SyncChannel* channel(); // AutomationMessageSender implementation. virtual bool Send(IPC::Message* message) WARN_UNUSED_RESULT; |