diff options
| author | hbono@chromium.org <hbono@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-15 03:48:36 +0000 |
|---|---|---|
| committer | hbono@chromium.org <hbono@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-15 03:48:36 +0000 |
| commit | 202e7a773359b24943d7de0943dd9c7d257ab1cb (patch) | |
| tree | 0f577db9ffb30c3c0a5b50f94e95ba00c137d83d /chrome/test/automation/automation_proxy.h | |
| parent | f73d4744cf1ca00ca6e5dbd669d4a57be2ff6b92 (diff) | |
| download | chromium_src-202e7a773359b24943d7de0943dd9c7d257ab1cb.zip chromium_src-202e7a773359b24943d7de0943dd9c7d257ab1cb.tar.gz chromium_src-202e7a773359b24943d7de0943dd9c7d257ab1cb.tar.bz2 | |
Fixed 3 tests that failed in hebrew enabled vista
BrowserTest.NoTitle
BrowserTest.Title
AutomationProxyVisibleTest.WindowGetViewBounds
Some notes :
There has been a small regression in the UI tests which makes them
get stuck even more on my very slow machine (maybe race conditions)
however, the fixes i post here do not make this state any worse
and fix these 3 tests above which always failed
TEST=1. run ui_tests on a RTL windows (or use --extra-chrome-flags=--lang=he)
2. the 3 tests listed above will always fail, as they expect LTR behavior
3. this fixes it
BUG=12636 http://code.google.com/p/chromium/issues/detail?id=12636
Original Patch by Yoav Zilberberg <yoav.zilberberg@gmail.com>
Original review: http://codereview.chromium.org/118441
R=me,jeremy,sky
Review URL: http://codereview.chromium.org/125036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18370 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/automation/automation_proxy.h')
| -rw-r--r-- | chrome/test/automation/automation_proxy.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/chrome/test/automation/automation_proxy.h b/chrome/test/automation/automation_proxy.h index 11bf615..2271f83 100644 --- a/chrome/test/automation/automation_proxy.h +++ b/chrome/test/automation/automation_proxy.h @@ -98,6 +98,11 @@ class AutomationProxy : public IPC::Channel::Listener, // False likely indicates an IPC error. bool GetNormalBrowserWindowCount(int* num_windows); + // Gets the locale of the chrome browser, currently all browsers forked from + // the main chrome share the same UI locale, returning true on success. + // False likely indicates an IPC error. + bool GetBrowserLocale(string16* locale); + // Returns whether an app modal dialog window is showing right now (i.e., a // javascript alert), and what buttons it contains. bool GetShowingAppModalDialog(bool* showing_app_modal_dialog, |