summaryrefslogtreecommitdiffstats
path: root/chrome/test/automation/automation_proxy_uitest.cc
diff options
context:
space:
mode:
authorphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-09 22:10:53 +0000
committerphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-09 22:10:53 +0000
commitbc2a2dd4edbc70339be723c5820d1e5b92fe9236 (patch)
tree81dcf133f11ddc2f84bd12d2b0848bfbf10abcbf /chrome/test/automation/automation_proxy_uitest.cc
parent6889a11308a11fbd1913a8e3d6901861b76c00c1 (diff)
downloadchromium_src-bc2a2dd4edbc70339be723c5820d1e5b92fe9236.zip
chromium_src-bc2a2dd4edbc70339be723c5820d1e5b92fe9236.tar.gz
chromium_src-bc2a2dd4edbc70339be723c5820d1e5b92fe9236.tar.bz2
Disable AutomationProxyVisibleTest.AutocompleteMatchesTest.
It is flaky, and the underlying automation seems to be horribly broken. I'm going to be fixing that in small steps. Disabling the test is the first one. TEST=none http://crbug.com/19876 Review URL: http://codereview.chromium.org/193064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25801 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/automation/automation_proxy_uitest.cc')
-rw-r--r--chrome/test/automation/automation_proxy_uitest.cc6
1 files changed, 2 insertions, 4 deletions
diff --git a/chrome/test/automation/automation_proxy_uitest.cc b/chrome/test/automation/automation_proxy_uitest.cc
index 0f6ae6b..2566bb8 100644
--- a/chrome/test/automation/automation_proxy_uitest.cc
+++ b/chrome/test/automation/automation_proxy_uitest.cc
@@ -981,9 +981,8 @@ TEST_F(AutomationProxyTest, AutocompleteParallelProxy) {
#endif // defined(OS_WIN) || defined(OS_LINUX)
-// Not run on linux because of flakiness. http://crbug.com/19876
-#if defined(OS_WIN)
-TEST_F(AutomationProxyVisibleTest, AutocompleteMatchesTest) {
+// So flaky, http://crbug.com/19876. Consult phajdan.jr before re-enabling.
+TEST_F(AutomationProxyVisibleTest, DISABLED_AutocompleteMatchesTest) {
scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
ASSERT_TRUE(browser.get());
scoped_refptr<AutocompleteEditProxy> edit(
@@ -1000,7 +999,6 @@ TEST_F(AutomationProxyVisibleTest, AutocompleteMatchesTest) {
EXPECT_TRUE(edit->GetAutocompleteMatches(&matches));
EXPECT_FALSE(matches.empty());
}
-#endif // defined(OS_WIN)
// Disabled because flaky see bug #5314.
TEST_F(AutomationProxyTest, DISABLED_AppModalDialogTest) {