summaryrefslogtreecommitdiffstats
path: root/chrome/test/automation/browser_proxy.h
diff options
context:
space:
mode:
authorjcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-01-21 01:08:44 +0000
committerjcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-01-21 01:08:44 +0000
commit58567187439fdcad4cf4fdc39a1d92668b7afbb8 (patch)
treeb1937e9f7214032957a666af48aee5ead0decd67 /chrome/test/automation/browser_proxy.h
parent81caffea3793f22bbbe26476fa8950031b6d88e8 (diff)
downloadchromium_src-58567187439fdcad4cf4fdc39a1d92668b7afbb8.zip
chromium_src-58567187439fdcad4cf4fdc39a1d92668b7afbb8.tar.gz
chromium_src-58567187439fdcad4cf4fdc39a1d92668b7afbb8.tar.bz2
A crasher would happen if you navigate to a page triggering an interstitial from the new tab page, then press back in the interstitial.
The crasher would happen because the navigation controller collects (destroys) the previous tab contents when a navigation is initiated. In this case, when navigating back (by just discarding the non committed entries), it would not be expect that the tab contents would be NULL. It seems we do not need to collect the unused tab contents on NavigateToPendingEntry() since we are collecting any unused TabContents in NavigationController::RendererDidNavigate(). BUG=6408 TEST=From the new page, enter the URL to a malware site (ex: http://ianfette.org), press Back (or close the tab), there should be no crash. Review URL: http://codereview.chromium.org/18433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8350 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/automation/browser_proxy.h')
0 files changed, 0 insertions, 0 deletions