diff options
author | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-16 17:05:11 +0000 |
---|---|---|
committer | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-16 17:05:11 +0000 |
commit | 9c9c761a2e070a8a6eb00f22a4365fc6cc2e1eff (patch) | |
tree | 11e6d28d263457e00395401c938ff5fb45d6eba6 /chrome/test/automation/tab_proxy.cc | |
parent | 6920f5ac0d0ea336b79f02b5d36751d1043ace29 (diff) | |
download | chromium_src-9c9c761a2e070a8a6eb00f22a4365fc6cc2e1eff.zip chromium_src-9c9c761a2e070a8a6eb00f22a4365fc6cc2e1eff.tar.gz chromium_src-9c9c761a2e070a8a6eb00f22a4365fc6cc2e1eff.tar.bz2 |
Removes entirely dead code paths related to ConstrainedWindows.
- Removes parts of the interface that probably made sense at some time, but now only have a DLOG(INFO) as their implementation. Also remove their callers.
- Remove all usage of the ConstrainedWindowProxy interface in the automation system. It was *never* used.
- Rename constrianed_window_impl_interactive_uitests.cc to blocked_popup_container_interactive_uitest.cc. The test case hasn't tested code in constrained_window_impl.cc since the rewrite of the blocked popup system back last autumn.
Review URL: http://codereview.chromium.org/125160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18498 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/automation/tab_proxy.cc')
-rw-r--r-- | chrome/test/automation/tab_proxy.cc | 28 |
1 files changed, 0 insertions, 28 deletions
diff --git a/chrome/test/automation/tab_proxy.cc b/chrome/test/automation/tab_proxy.cc index f81e23b..dea3a54 100644 --- a/chrome/test/automation/tab_proxy.cc +++ b/chrome/test/automation/tab_proxy.cc @@ -11,7 +11,6 @@ #include "chrome/test/automation/automation_constants.h" #include "chrome/test/automation/automation_messages.h" #include "chrome/test/automation/automation_proxy.h" -#include "chrome/test/automation/constrained_window_proxy.h" #include "googleurl/src/gurl.h" bool TabProxy::GetTabTitle(std::wstring* title) const { @@ -324,33 +323,6 @@ bool TabProxy::GetConstrainedWindowCount(int* count) const { 0, handle_, count)); } -scoped_refptr<ConstrainedWindowProxy> TabProxy::GetConstrainedWindow( - int window_index) const { - if (!is_valid()) - return NULL; - - int handle = 0; - if (!sender_->Send(new AutomationMsg_ConstrainedWindow(0, handle_, - window_index, - &handle))) - return NULL; - - if (handle == 0) - return NULL; - - ConstrainedWindowProxy* w = static_cast<ConstrainedWindowProxy*>( - tracker_->GetResource(handle)); - if (!w) { - w = new ConstrainedWindowProxy(sender_, tracker_, handle); - w->AddRef(); - } - - // Since there is no scoped_refptr::attach. - scoped_refptr<ConstrainedWindowProxy> result; - result.swap(&w); - return result; -} - bool TabProxy::WaitForChildWindowCountToChange(int count, int* new_count, int wait_timeout) { int intervals = std::min(wait_timeout/automation::kSleepTime, 1); |