diff options
| author | tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-10 15:20:27 +0000 |
|---|---|---|
| committer | tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-10 15:20:27 +0000 |
| commit | b9d227497415e92048d88f676b395fc81d175598 (patch) | |
| tree | e68597fada024167bbe52822c64d54c45b2dfa7f /chrome/test/automation/tab_proxy.cc | |
| parent | 3f1e7569c74e1d87c0038d4e3ddf4ee85511b9ff (diff) | |
| download | chromium_src-b9d227497415e92048d88f676b395fc81d175598.zip chromium_src-b9d227497415e92048d88f676b395fc81d175598.tar.gz chromium_src-b9d227497415e92048d88f676b395fc81d175598.tar.bz2 | |
Reapplying tab support (change 9388). I synced and re-applied my change and found the automation tests not hanging.
I also took a look at the logs from the hanging buildbots and the reverted change didn't touch on any of the code that appeared to be hanging.
I also put breakpoints on the modified functions while running ui_tests.exe and nothing hit, so it looks like a fluke.
I did get a hang though when running an old build of ui_tests.exe with a new version of chrome.dll.
Is there any chance that there could have been a stale version on the build bots?
Review URL: http://codereview.chromium.org/20214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9478 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/automation/tab_proxy.cc')
| -rw-r--r-- | chrome/test/automation/tab_proxy.cc | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/chrome/test/automation/tab_proxy.cc b/chrome/test/automation/tab_proxy.cc index 61b50cf..e0e6102 100644 --- a/chrome/test/automation/tab_proxy.cc +++ b/chrome/test/automation/tab_proxy.cc @@ -641,6 +641,14 @@ bool TabProxy::ProcessUnhandledAccelerator(const MSG& msg) { // This message expects no response } +bool TabProxy::SetInitialFocus(bool reverse) { + if (!is_valid()) + return false; + return sender_->Send( + new AutomationMsg_SetInitialFocus(0, handle_, reverse)); + // This message expects no response +} + bool TabProxy::WaitForTabToBeRestored(uint32 timeout_ms) { if (!is_valid()) return false; |