diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-16 17:05:06 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-16 17:05:06 +0000 |
| commit | da5c4fc231cd747f5c938fdf737d37c23615205e (patch) | |
| tree | c2ae73b2449baaa1998965fabecc755806752041 /chrome/test/automation/tab_proxy.cc | |
| parent | 2b1880cb8f1042235f4242b6ec571e606de8e4bc (diff) | |
| download | chromium_src-da5c4fc231cd747f5c938fdf737d37c23615205e.zip chromium_src-da5c4fc231cd747f5c938fdf737d37c23615205e.tar.gz chromium_src-da5c4fc231cd747f5c938fdf737d37c23615205e.tar.bz2 | |
Speculative fix for a crash and tweak to
menus. MenuButton::OnKeyPressed may run a nested message loop, which
means by the time it returns 'this' may have been deleted (a couple of
crashes seem to indicate this). In talking with Domnic the code after
the call to Activate isn't necessary, so I'm removing it.
I'm also changing the cancel call in MenuRunner to supply
EXIT_DESTROYED, which means the menu code won't attempt to touch the
button that was supplied to run. This is necessary as if MenuRunner is
deleted the chances are the button supplied to it has also been
deleted.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7890073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101500 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/automation/tab_proxy.cc')
0 files changed, 0 insertions, 0 deletions