diff options
author | bauerb@chromium.org <bauerb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-21 07:31:11 +0000 |
---|---|---|
committer | bauerb@chromium.org <bauerb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-21 07:31:11 +0000 |
commit | c70f9b84b30986220dc58993a9a41d6fdebefac2 (patch) | |
tree | bfd1dd487c509f9bfb65b065293d300c934b9282 /chrome/test/automation/tab_proxy.h | |
parent | 2f312ab5f419b77456eba5e0362af3adaf94f6ad (diff) | |
download | chromium_src-c70f9b84b30986220dc58993a9a41d6fdebefac2.zip chromium_src-c70f9b84b30986220dc58993a9a41d6fdebefac2.tar.gz chromium_src-c70f9b84b30986220dc58993a9a41d6fdebefac2.tar.bz2 |
Close a newly opened (by cmd-clicking on a link) tab if it resulted in a download.
To test this, the CL adds an automation message AutomationMsg_NavigateAsyncWithDisposition, and a method NavigateToURLAsyncWithDisposition to TabProxy.
The only functional change is in TabContents::OnStartDownload, the rest of the changes is for testing.
BUG=10764
TEST=DownloadTest.CloseNewTab
Manual test: go to http://build.chromium.org/buildbot/continuous/mac/LATEST/, open the link "chrome-mac.zip" in a new tab. The tab should close as soon as the download starts.
Review URL: http://codereview.chromium.org/1151007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45158 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/automation/tab_proxy.h')
-rw-r--r-- | chrome/test/automation/tab_proxy.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/chrome/test/automation/tab_proxy.h b/chrome/test/automation/tab_proxy.h index ad28090..7fabc50 100644 --- a/chrome/test/automation/tab_proxy.h +++ b/chrome/test/automation/tab_proxy.h @@ -150,6 +150,12 @@ class TabProxy : public AutomationResourceProxy, // TabProxy we attach won't know about it. See bug 666730. bool NavigateToURLAsync(const GURL& url) WARN_UNUSED_RESULT; + // Asynchronously navigates to a url using a non-default disposition. + // This can be used for example to open a URL in a new tab. + bool NavigateToURLAsyncWithDisposition( + const GURL& url, + WindowOpenDisposition disposition) WARN_UNUSED_RESULT; + // Replaces a vector contents with the redirect chain out of the given URL. // Returns true on success. Failure may be due to being unable to send the // message, parse the response, or a failure of the history system in the |