diff options
author | jcampan@google.com <jcampan@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-04 20:40:50 +0000 |
---|---|---|
committer | jcampan@google.com <jcampan@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-04 20:40:50 +0000 |
commit | 719ead5027772e9be7708cb2414a95df5499595f (patch) | |
tree | ff679301ac868278c5479ff2d2d75b7175699540 /chrome/test/automation | |
parent | c783216a001ae7885730700a7d3a6d7fcf4fba97 (diff) | |
download | chromium_src-719ead5027772e9be7708cb2414a95df5499595f.zip chromium_src-719ead5027772e9be7708cb2414a95df5499595f.tar.gz chromium_src-719ead5027772e9be7708cb2414a95df5499595f.tar.bz2 |
Reverting my last commit, it seems to cause regression on the page cycler tests.
TBR=beng
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@337 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/automation')
-rw-r--r-- | chrome/test/automation/automation_messages_internal.h | 12 | ||||
-rw-r--r-- | chrome/test/automation/browser_proxy.cc | 21 | ||||
-rw-r--r-- | chrome/test/automation/browser_proxy.h | 5 |
3 files changed, 1 insertions, 37 deletions
diff --git a/chrome/test/automation/automation_messages_internal.h b/chrome/test/automation/automation_messages_internal.h index 6709e4d..64ee503 100644 --- a/chrome/test/automation/automation_messages_internal.h +++ b/chrome/test/automation/automation_messages_internal.h @@ -160,7 +160,7 @@ IPC_BEGIN_MESSAGES(Automation, 0) IPC_MESSAGE_ROUTED1(AutomationMsg_TabTitleRequest, int) IPC_MESSAGE_ROUTED2(AutomationMsg_TabTitleResponse, int, std::wstring) - // This message requests the url of the tab with the given handle. + // This message requests the the url of the tab with the given handle. // The response contains a success flag and the URL string. The URL will // be empty on failure, and it still may be empty on success. IPC_MESSAGE_ROUTED1(AutomationMsg_TabURLRequest, @@ -177,16 +177,6 @@ IPC_BEGIN_MESSAGES(Automation, 0) IPC_MESSAGE_ROUTED1(AutomationMsg_WindowHWNDResponse, HWND /* Win32 handle */) - // This message requests the execution of a browser command in the browser - // for which the handle is specified. - // The response contains a boolean, whether the command execution was - // successful. - IPC_MESSAGE_ROUTED2(AutomationMsg_WindowExecuteCommandRequest, - int /* automation handle */, - int /* browser command */) - IPC_MESSAGE_ROUTED1(AutomationMsg_WindowExecuteCommandResponse, - bool /* success flag */) - // This message notifies the AutomationProxy that a handle that it has // previously been given is now invalid. (For instance, if the handle // represented a window which has now been closed.) The parameter diff --git a/chrome/test/automation/browser_proxy.cc b/chrome/test/automation/browser_proxy.cc index 68e41ba..81b8900 100644 --- a/chrome/test/automation/browser_proxy.cc +++ b/chrome/test/automation/browser_proxy.cc @@ -346,24 +346,3 @@ bool BrowserProxy::GetHWND(HWND* handle) const { return succeeded; } - -bool BrowserProxy::RunCommand(int browser_command) const { - if (!is_valid()) - return false; - - IPC::Message* response = NULL; - bool succeeded = sender_->SendAndWaitForResponse( - new AutomationMsg_WindowExecuteCommandRequest(0, handle_, browser_command), - &response, AutomationMsg_WindowExecuteCommandResponse::ID); - - scoped_ptr<IPC::Message> response_deleter(response); // Delete on return. - if (!succeeded) - return false; - - bool success = false; - if (AutomationMsg_WindowExecuteCommandResponse::Read(response, &success)) - return success; - - // We failed to deserialize the returned value. - return false; -} diff --git a/chrome/test/automation/browser_proxy.h b/chrome/test/automation/browser_proxy.h index 17d7385..469b377 100644 --- a/chrome/test/automation/browser_proxy.h +++ b/chrome/test/automation/browser_proxy.h @@ -157,11 +157,6 @@ class BrowserProxy : public AutomationResourceProxy { // reference build. bool GetHWND(HWND* handle) const; - // Run the specified command in the browser (see browser_commands.cc for the - // list of supported commands). Returns true if the command was successfully - // executed, false otherwise. - bool RunCommand(int browser_command) const; - private: DISALLOW_EVIL_CONSTRUCTORS(BrowserProxy); }; |