diff options
| author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-29 20:35:19 +0000 |
|---|---|---|
| committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-29 20:35:19 +0000 |
| commit | ddd231eaa03153f6d04894cceb0b4480755e1277 (patch) | |
| tree | faafed02945c1f8934e6e393ac0c6b094c303cdf /chrome/test/automation | |
| parent | c5e30d8572ffae1e0d4fbb2fff765f9a8cbace77 (diff) | |
| download | chromium_src-ddd231eaa03153f6d04894cceb0b4480755e1277.zip chromium_src-ddd231eaa03153f6d04894cceb0b4480755e1277.tar.gz chromium_src-ddd231eaa03153f6d04894cceb0b4480755e1277.tar.bz2 | |
Change a bunch of string types.
Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters).
TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring.
BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/2854015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51157 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/automation')
| -rw-r--r-- | chrome/test/automation/automation_messages_internal.h | 2 | ||||
| -rw-r--r-- | chrome/test/automation/browser_proxy.cc | 2 | ||||
| -rw-r--r-- | chrome/test/automation/browser_proxy.h | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/chrome/test/automation/automation_messages_internal.h b/chrome/test/automation/automation_messages_internal.h index 9e37390..208dba6 100644 --- a/chrome/test/automation/automation_messages_internal.h +++ b/chrome/test/automation/automation_messages_internal.h @@ -833,7 +833,7 @@ IPC_BEGIN_MESSAGES(Automation) IPC_SYNC_MESSAGE_ROUTED3_1(AutomationMsg_SetStringPreference, int /* browser handle */, std::wstring /* pref name */, - std::wstring /* pref value */, + std::string /* pref value */, bool) // This messages gets a boolean-value preference. diff --git a/chrome/test/automation/browser_proxy.cc b/chrome/test/automation/browser_proxy.cc index 5b5efca..670ee5d 100644 --- a/chrome/test/automation/browser_proxy.cc +++ b/chrome/test/automation/browser_proxy.cc @@ -412,7 +412,7 @@ bool BrowserProxy::SetIntPreference(const std::wstring& name, int value) { } bool BrowserProxy::SetStringPreference(const std::wstring& name, - const std::wstring& value) { + const std::string& value) { if (!is_valid()) return false; diff --git a/chrome/test/automation/browser_proxy.h b/chrome/test/automation/browser_proxy.h index 7a7846c..4f48e51 100644 --- a/chrome/test/automation/browser_proxy.h +++ b/chrome/test/automation/browser_proxy.h @@ -184,7 +184,7 @@ class BrowserProxy : public AutomationResourceProxy { // Sets the string value of the specified preference. bool SetStringPreference(const std::wstring& name, - const std::wstring& value) WARN_UNUSED_RESULT; + const std::string& value) WARN_UNUSED_RESULT; // Gets the boolean value of the specified preference. bool GetBooleanPreference(const std::wstring& name, |