summaryrefslogtreecommitdiffstats
path: root/chrome/test/base/testing_browser_process.h
diff options
context:
space:
mode:
authorjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-11 05:41:40 +0000
committerjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-11 05:41:40 +0000
commit99907365ccdfb821ab0c34e36dadcb26ce25f20e (patch)
tree8676bbe1bfebcf35c0f71d31b06b2c9f1e2afb6f /chrome/test/base/testing_browser_process.h
parent57b8bb357db85d85157c3a87f0b87383343867d8 (diff)
downloadchromium_src-99907365ccdfb821ab0c34e36dadcb26ce25f20e.zip
chromium_src-99907365ccdfb821ab0c34e36dadcb26ce25f20e.tar.gz
chromium_src-99907365ccdfb821ab0c34e36dadcb26ce25f20e.tar.bz2
Move creation and ownership of ResourceDispatcherHost and PluginService to content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads) -avoid having to tell embedders about specifics of BrowserThread startup/shutdown -move ResourceDispatcherHost's getter to content where it belongs I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117078 Review URL: http://codereview.chromium.org/9150016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117171 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/base/testing_browser_process.h')
-rw-r--r--chrome/test/base/testing_browser_process.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/test/base/testing_browser_process.h b/chrome/test/base/testing_browser_process.h
index 4f0fc10..db62178 100644
--- a/chrome/test/base/testing_browser_process.h
+++ b/chrome/test/base/testing_browser_process.h
@@ -47,8 +47,8 @@ class TestingBrowserProcess : public BrowserProcess {
TestingBrowserProcess();
virtual ~TestingBrowserProcess();
+ virtual void ResourceDispatcherHostCreated() OVERRIDE;
virtual void EndSession() OVERRIDE;
- virtual ResourceDispatcherHost* resource_dispatcher_host() OVERRIDE;
virtual MetricsService* metrics_service() OVERRIDE;
virtual IOThread* io_thread() OVERRIDE;
virtual WatchDogThread* watchdog_thread() OVERRIDE;