diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-20 12:56:43 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-20 12:56:43 +0000 |
| commit | bed76fded2fb471c26e6f78c6709fb3c3e5a04a3 (patch) | |
| tree | 29404fe76173adc18407a3ce4b55a4f10a558679 /chrome/test/browser | |
| parent | 64569cce3a56ca39eea8712a4f91caad7de32be2 (diff) | |
| download | chromium_src-bed76fded2fb471c26e6f78c6709fb3c3e5a04a3.zip chromium_src-bed76fded2fb471c26e6f78c6709fb3c3e5a04a3.tar.gz chromium_src-bed76fded2fb471c26e6f78c6709fb3c3e5a04a3.tar.bz2 | |
Fix a crash on browser exit after opening TaskManager.
TaskManager is a singleton, so it's destroyed by AtExitManager. At the time
of destruction it cannot register AtExit callbacks (AtExitManager requires
that). It turns out that some Windows view code wants to register an AtExit
callback during destruction.
For more info about view code, see http://src.chromium.org/viewvc/chrome?view=rev&revision=9161
The fix is to destroy the view early, using EnsureShutdown static method
of TaskManager. It was also necessary to delete child views a bit earlier
to avoid another crashed.
Added a regression browser_test and verified that it's broken without this fix.
http://crbug.com/11180
Review URL: http://codereview.chromium.org/114031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16474 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/browser')
| -rw-r--r-- | chrome/test/browser/browser_tests_dll.vcproj | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/chrome/test/browser/browser_tests_dll.vcproj b/chrome/test/browser/browser_tests_dll.vcproj index 4013695..9f9a321 100644 --- a/chrome/test/browser/browser_tests_dll.vcproj +++ b/chrome/test/browser/browser_tests_dll.vcproj @@ -203,6 +203,14 @@ </File>
</Filter>
<Filter
+ Name="TestTaskManager"
+ >
+ <File
+ RelativePath="..\..\browser\task_manager_browsertest.cc"
+ >
+ </File>
+ </Filter>
+ <Filter
Name="TestSSL"
>
<File
|