Fix bug with context menus in incognito mode.

If an extension uses "spanning" mode, the context menu items are shared
between profiles. If an extension uses "split" mode, the items are separate
per profile. In either case, they only appear in incognito if the extension is
enabled in incognito.

Also fixed a minor bug, so that tabs.create now can open extension URLs in
incognito if the extension uses split mode.

BUG=61147
TEST=see bug for repro steps; context menu items should work in incognito mode

Review URL: http://codereview.chromium.org/4090011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64812 0039d316-1c4b-4281-b951-d872f2087c98

3 files changed, 27 insertions, 0 deletions

diff --git a/chrome/test/data/extensions/context_menus/incognito/background.html b/chrome/test/data/extensions/context_menus/incognito/background.html
new file mode 100644
index 0000000..46f4d74
--- /dev/null
+++ b/chrome/test/data/extensions/context_menus/incognito/background.html
@@ -0,0 +1 @@
+<script src="test.js"></script>
diff --git a/chrome/test/data/extensions/context_menus/incognito/manifest.json b/chrome/test/data/extensions/context_menus/incognito/manifest.json
new file mode 100644
index 0000000..560ca13
--- /dev/null
+++ b/chrome/test/data/extensions/context_menus/incognito/manifest.json
@@ -0,0 +1,7 @@
+{
+  "name": "Tests that context menus work properly in incognito split mode",
+  "version": "0.1",
+  "permissions": ["contextMenus"],
+  "incognito": "split",
+  "background_page": "background.html"
+}
diff --git a/chrome/test/data/extensions/context_menus/incognito/test.js b/chrome/test/data/extensions/context_menus/incognito/test.js
new file mode 100644
index 0000000..c64b01a
--- /dev/null
+++ b/chrome/test/data/extensions/context_menus/incognito/test.js
@@ -0,0 +1,19 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+var inIncognitoContext = chrome.extension.inIncognitoContext;
+var incognitoStr = inIncognitoContext ? "incognito" : "regular";
+
+function onclick(info) {
+  chrome.test.sendMessage("onclick fired " + incognitoStr);
+}
+
+window.onload = function() {
+  chrome.contextMenus.create({title: "item " + incognitoStr,
+                              onclick: onclick}, function() {
+    if (!chrome.extension.lastError) {
+      chrome.test.sendMessage("created item " + incognitoStr);
+    }
+  });
+};