diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-09 21:30:53 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-09 21:30:53 +0000 |
| commit | 361b28a80cfd2a9a0db454c7ebdb9c95ea55840c (patch) | |
| tree | a6cf253e64ded952e1a5518f8d25ac8848c6200b /chrome/test/data/feeds | |
| parent | 76b118a0f798a2e88103492173225e57b2062a37 (diff) | |
| download | chromium_src-361b28a80cfd2a9a0db454c7ebdb9c95ea55840c.zip chromium_src-361b28a80cfd2a9a0db454c7ebdb9c95ea55840c.tar.gz chromium_src-361b28a80cfd2a9a0db454c7ebdb9c95ea55840c.tar.bz2 | |
Add a rudamentary feed preview to the RSS extension. It
doesn't handle inline HTML in the item description (it just
dumps it as text) and the feed needs to be valid XML for it
to show any preview, but it is better than nothing. We can
easily change it to display the HTML but we want to (at some
point) try to use a separate origin so that we can render
the HTML code from untrusted sources safely.
Also fix a bug in the image tracker. It should not try
to communicate with the view if the view has gone away
(which was the whole point of the image tracker...)
BUG=None
TEST=Install the extension, browse to a page with a feed
and click onthe rss icon in the Omnibox. An interstitial
page should appear with a preview of the feed.
Review URL: http://codereview.chromium.org/155180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20316 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/data/feeds')
| -rw-r--r-- | chrome/test/data/feeds/feed.html | 8 | ||||
| -rw-r--r-- | chrome/test/data/feeds/feed1.xml | 10 | ||||
| -rw-r--r-- | chrome/test/data/feeds/feed2.xml | 9 | ||||
| -rw-r--r-- | chrome/test/data/feeds/feed_invalid1.xml | 0 | ||||
| -rw-r--r-- | chrome/test/data/feeds/feed_invalid2.xml | 1 | ||||
| -rw-r--r-- | chrome/test/data/feeds/no_feed.html | 7 |
6 files changed, 35 insertions, 0 deletions
diff --git a/chrome/test/data/feeds/feed.html b/chrome/test/data/feeds/feed.html new file mode 100644 index 0000000..a776481 --- /dev/null +++ b/chrome/test/data/feeds/feed.html @@ -0,0 +1,8 @@ +<html> +<head> + <link rel="alternate" type="application/rss+xml" title="RSS" href="feed1.xml"/> +</head> +<body> + This is a page with a feed link. +</body> +</html> diff --git a/chrome/test/data/feeds/feed1.xml b/chrome/test/data/feeds/feed1.xml new file mode 100644 index 0000000..b480fdf --- /dev/null +++ b/chrome/test/data/feeds/feed1.xml @@ -0,0 +1,10 @@ +<rss version="2.0">
+<channel>
+ <title>MyFeedTitle</title>
+ <item>
+ <title>Title 1</title>
+ <link>http://www.google.com</link>
+ <description>Desc</description>
+ </item>
+</channel>
+</rss>
\ No newline at end of file diff --git a/chrome/test/data/feeds/feed2.xml b/chrome/test/data/feeds/feed2.xml new file mode 100644 index 0000000..aff3bf2 --- /dev/null +++ b/chrome/test/data/feeds/feed2.xml @@ -0,0 +1,9 @@ +<feed>
+ <title>MyFeed2</title>
+
+ <entry>
+ <title>My item title1</title>
+ <link rel="alternate" type="text/html" href="http://www.google.com" />
+ <summary>This is a summary.</summary>
+ </entry>
+</feed>
\ No newline at end of file diff --git a/chrome/test/data/feeds/feed_invalid1.xml b/chrome/test/data/feeds/feed_invalid1.xml new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/chrome/test/data/feeds/feed_invalid1.xml diff --git a/chrome/test/data/feeds/feed_invalid2.xml b/chrome/test/data/feeds/feed_invalid2.xml new file mode 100644 index 0000000..b24b52b --- /dev/null +++ b/chrome/test/data/feeds/feed_invalid2.xml @@ -0,0 +1 @@ +This is a garbage feed.
\ No newline at end of file diff --git a/chrome/test/data/feeds/no_feed.html b/chrome/test/data/feeds/no_feed.html new file mode 100644 index 0000000..9151a8c --- /dev/null +++ b/chrome/test/data/feeds/no_feed.html @@ -0,0 +1,7 @@ +<html> +<head> +</head> +<body> + This is a page with no feed link. +</body> +</html> |