diff options
| author | jnd@google.com <jnd@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-20 11:58:08 +0000 |
|---|---|---|
| committer | jnd@google.com <jnd@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-20 11:58:08 +0000 |
| commit | 81454fa4add65101f232c18ba42838be9fe2c608 (patch) | |
| tree | 9dde0ffbe0d38dc37833fbfda8b4b0dd3d8ec49b /chrome/test/data | |
| parent | 08fbc859c68ec143de89ae679ee03881ee22a94c (diff) | |
| download | chromium_src-81454fa4add65101f232c18ba42838be9fe2c608.zip chromium_src-81454fa4add65101f232c18ba42838be9fe2c608.tar.gz chromium_src-81454fa4add65101f232c18ba42838be9fe2c608.tar.bz2 | |
Revert 56834 - Fix a few test failures when landing http://trac.webkit.org/changeset/57178.
http://trac.webkit.org/changeset/57178 broke some tests in browser_test and ui_test.
In the test RedirectTest.ClientCancelled, it needs a user-initiated event to trigger the redirect, now it uses "javaScript:click()". When landing r57178, the call of window.open which is inside the call of javaScript:click() was treated as non user-initiated, so the in-page location change was treated as client redirect and the redirect was recoreded, that is why this test was failed when landing r57178. (Please refer to the logic in FrameLoaderClientImpl::dispatchDidNavigateWithinPage.)
In the tests AppApiTest.AppProcess, ExtensionBrowserTest.WindowOpenExtension and ExtensionBrowserTest.WindowOpenInvalidExtension, they assume the new tabs opened by window.open in current window. But when landing r57178, since those calls of window.open were treated as non user-initiated, the disposition type of new tabs were changed to Popup, which caused a few new tabs were created instead of a few new tabs in current window (Please refer to RenderView::show), which cause those tests were failed when landing r57178.), that is why those tests were failed when landing r57178.
BUG=17655
TEST=RedirectTest.ClientCancelled, AppApiTest.AppProcess, ExtensionBrowserTest.WindowOpenExtension, ExtensionBrowserTest.WindowOpenInvalidExtension
Review URL: http://codereview.chromium.org/3136019
TBR=jnd@google.com
Review URL: http://codereview.chromium.org/3174023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56850 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/data')
| -rw-r--r-- | chrome/test/data/cancelled_redirect_test.html | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/test/data/cancelled_redirect_test.html b/chrome/test/data/cancelled_redirect_test.html index 713a4dd..bccd211 100644 --- a/chrome/test/data/cancelled_redirect_test.html +++ b/chrome/test/data/cancelled_redirect_test.html @@ -13,7 +13,7 @@ meta-refresh timer is scheduled, so we use a non-zero timeout of 1msec for this. } </script> </head> - <body onclick="click()"> + <body> <input type="button" id="mybutton" onclick="document.location='#myanchor'"/> <a name="myanchor">Anchor</a><br/> </body> |