diff options
| author | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-28 18:12:55 +0000 |
|---|---|---|
| committer | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-28 18:12:55 +0000 |
| commit | 13f383ff5fc8ff095501794d4ce758f0067ff9b5 (patch) | |
| tree | ceb1d08f38759bf8805ede009924a990bae496e5 /chrome/test/in_process_browser_test.h | |
| parent | f61f331824ac9c98684a886be0d918aefe69d3ce (diff) | |
| download | chromium_src-13f383ff5fc8ff095501794d4ce758f0067ff9b5.zip chromium_src-13f383ff5fc8ff095501794d4ce758f0067ff9b5.tar.gz chromium_src-13f383ff5fc8ff095501794d4ce758f0067ff9b5.tar.bz2 | |
Assert that thread-safe reference counting is used with
cross-thread NewRunnableMethod.
This assertion caught such an error in VisitedLinkMaster!
My approach, modify RunnableMethodTraits<T> to assert that
when ReleaseCallee happens on a different thread from
RetainCallee that the type supports thread-safe reference
counting. I do this by adding a static method to both
RefCounted<T> and RefCountedThreadSafe<T>.
This results in a little ugliness in cases where people
implement AddRef and Release by hand (to make the no-ops).
There may be a nicer way to deal with those few cases.
R=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/251012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27379 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/in_process_browser_test.h')
| -rw-r--r-- | chrome/test/in_process_browser_test.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/test/in_process_browser_test.h b/chrome/test/in_process_browser_test.h index 2f519b7..ace6e07 100644 --- a/chrome/test/in_process_browser_test.h +++ b/chrome/test/in_process_browser_test.h @@ -45,6 +45,7 @@ class InProcessBrowserTest : public testing::Test { // We do this so we can be used in a Task. void AddRef() {} void Release() {} + static bool ImplementsThreadSafeReferenceCounting() { return false; } // Configures everything for an in process browser test, then invokes // BrowserMain. BrowserMain ends up invoking RunTestOnMainThreadLoop. |