Eliminate all uses of strerror() in code that uses src/base. strerror() is inherently unsafe in multi-threaded apps because it stores the string in a global buffer. It should never be used. If you want to log an error, use PLOG and friends, or if that's too high-level then use safe_strerror().

TEST=built on Linux in 32-bit and 64-bit mode; ran base_unittests in each case; ran Chromium itself in each case; try servers
BUG=none

Review URL: http://codereview.chromium.org/261055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28850 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 3 insertions, 3 deletions

diff --git a/chrome/test/page_cycler/page_cycler_test.cc b/chrome/test/page_cycler/page_cycler_test.cc
index 7c611d5..d950f14 100644
--- a/chrome/test/page_cycler/page_cycler_test.cc
+++ b/chrome/test/page_cycler/page_cycler_test.cc
@@ -52,7 +52,7 @@ rlim_t GetFileDescriptorLimit(void) {
   if (getrlimit(RLIMIT_NOFILE, &limits) == 0) {
     return limits.rlim_cur;
   }
-  LOG(ERROR) << "Failed to get file descriptor limit: " << strerror(errno);
+  PLOG(ERROR) << "Failed to get file descriptor limit";
   return 0;
 }
 
@@ -65,10 +65,10 @@ void SetFileDescriptorLimit(rlim_t max_descriptors) {
       limits.rlim_cur = std::min(max_descriptors, limits.rlim_max);
     }
     if (setrlimit(RLIMIT_NOFILE, &limits) != 0) {
-      LOG(ERROR) << "Failed to set file descriptor limit: " << strerror(errno);
+      PLOG(ERROR) << "Failed to set file descriptor limit";
     }
   } else {
-    LOG(ERROR) << "Failed to get file descriptor limit: " << strerror(errno);
+    PLOG(ERROR) << "Failed to get file descriptor limit";
   }
 }