diff options
author | sullivan@chromium.org <sullivan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-04 15:05:58 +0000 |
---|---|---|
committer | sullivan@chromium.org <sullivan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-04 15:05:58 +0000 |
commit | 4ab59f6bb8013f654a6aff50e5b8a84fb6612f6f (patch) | |
tree | ffad14c85e90f999241ce0f38ea6188443ff74f2 /chrome/test/perf | |
parent | e5afccdf4b24336db44842aefe00712a1751797d (diff) | |
download | chromium_src-4ab59f6bb8013f654a6aff50e5b8a84fb6612f6f.zip chromium_src-4ab59f6bb8013f654a6aff50e5b8a84fb6612f6f.tar.gz chromium_src-4ab59f6bb8013f654a6aff50e5b8a84fb6612f6f.tar.bz2 |
Revert 191854 "Delete CopyRecursiveDirNoCache from test_file_util."
> Delete CopyRecursiveDirNoCache from test_file_util.
>
> This function was used in only one place and that place was wrong.
>
> The implementation was long and complicated on Windows, and long and
> complicated and copied verbatim from elsewhere with 3 lines different on Posix.
>
> The place it was used was in the proxy launcher when copying the profile. It's
> not clear to me why we wouldn't want the profile files in the filesystem cache
> when running tests. Quite the opposite, we want the tests to run as fast as
> possible.
>
> The only place this should matter is in the startup tests. And the startup
> tests do things to the profile after it gets copied that should page some files
> back in! This adds another step to the startup tests to evict the profile files
> for cold startup tests only.
>
> BUG=
>
> Review URL: https://codereview.chromium.org/13394003
TBR=brettw@chromium.org
BUG=226099
Review URL: https://codereview.chromium.org/13459005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192335 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/perf')
-rw-r--r-- | chrome/test/perf/startup_test.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/chrome/test/perf/startup_test.cc b/chrome/test/perf/startup_test.cc index 1d8243f..75f3154 100644 --- a/chrome/test/perf/startup_test.cc +++ b/chrome/test/perf/startup_test.cc @@ -239,12 +239,6 @@ class StartupTest : public UIPerfTest { dir_app.Append(FILE_PATH_LITERAL("chrome.dll"))); ASSERT_TRUE(EvictFileFromSystemCacheWrapper(chrome_dll)); #endif - - // Kick out the profile files. - file_util::FileEnumerator en(user_data_dir(), true, - file_util::FileEnumerator::FILES); - for (base::FilePath cur = en.Next(); !cur.empty(); cur = en.Next()) - EvictFileFromSystemCacheWrapper(cur); } UITest::SetUp(); TimeTicks end_time = TimeTicks::Now(); |