diff options
| author | brianderson@chromium.org <brianderson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-23 10:45:03 +0000 |
|---|---|---|
| committer | brianderson@chromium.org <brianderson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-23 10:45:03 +0000 |
| commit | c8cbae7f41a1212bce61523021a60ee78783993b (patch) | |
| tree | 8a57d88602df03a587c2dcd2a95039b20ec4ef83 /chrome/test/perf | |
| parent | 280755cad298b37cd6ead4d16337c4e1ed79f1a0 (diff) | |
| download | chromium_src-c8cbae7f41a1212bce61523021a60ee78783993b.zip chromium_src-c8cbae7f41a1212bce61523021a60ee78783993b.tar.gz chromium_src-c8cbae7f41a1212bce61523021a60ee78783993b.tar.bz2 | |
cc: Rename VSync to BeginFrame
We are replacing hard vsync scheduling with BeginFrame+deadline
intervals.
This patch removes references to vsync in CC where it will no
longer make sense. (One exception is cc::VSyncTimeSource, which
will be removed in future patches to be incorporated into the
scheduler itself.)
Additionally, BeginFrames are clarified with suffixes whenever
context is not enough and existing identifiers associated with
BeginFrame when it no longer makes sense are renamed.
A summary of the important renames are as follows:
Browser Side Renames:
COutputSurface::EnableVSyncNotification -> SetNeedsBeginFrame
COutputSurface::OnDidVSync -> OnBeginFrame
ViewHostMsg_SetVSyncNotificationEnabled -> ViewHostMsg_SetNeedsBeginFrame
ViewMsg_DidVSync -> ViewMsg_BeginFrame
Impl Side Renames:
LTHI::EnableVSyncNotification -> SetNeedsBeginFrame
LTHI::DidVSync -> BeginFrame
LTHI::DidRecieveLastInputEventForVSync -> DidReceiveLastInputEventForBeginFrame
Main+Impl Side Renames:
LTHIClient::DidVSync -> BeginFrameOnImplThread
LTHIClient::DidRecieveLastInputEventForVSync -> DidReceiveLastInputEventForBeginFrameOnImplThread
TProxy::BeginFrame -> BeginFrameOnMainThread
TProxy::ForceBeginFrameOnImplThread -> ForceCommitOnImplThread
TProxy::BeginFrameCompleteOnImplThread -> StartCommitOnImplThread
Scheduler::BeginFrameComplete -> FinishCommit
Scheduler::BeginFrameAborted -> BeginFrameAbortedByMainThread
Scheduler::LastVsyncTime -> LastBeginFrameOnImplThreadTime
Scheduler::VSyncTick -> BeginFrame
SchedulerSM::VSyncCallbackNeeded -> BeginFrameNeededByImplThread
SchedulerSM::ACTION_BEGIN_FRAME -> ACTION_SEND_BEGIN_FRAME_TO_MAIN_THREAD
FRC::DidBeginFrame -> DidSwapBuffers
FRC::DidFinishFrame -> DidSwapBuffersComplete
Random Renames:
LTSettings::render_vsync_enabled -> throttle_frame_production
LTSettings::render_vsync_notification_enabled -> render_parent_drives_begin_frame
LTSettings::synchronously_disable_vsync -> using_synchronous_renderer_compositor
RenderWidget::SynchronouslyDisableVSync -> UsingSynchronousRendererCompositor
BUG=240945
Review URL: https://chromiumcodereview.appspot.com/15058004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201739 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/perf')
| -rw-r--r-- | chrome/test/perf/rendering/latency_tests.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/test/perf/rendering/latency_tests.cc b/chrome/test/perf/rendering/latency_tests.cc index fdd00d7..af3c761 100644 --- a/chrome/test/perf/rendering/latency_tests.cc +++ b/chrome/test/perf/rendering/latency_tests.cc @@ -99,9 +99,9 @@ const int kInputsPerFrame = 16; const int kClearColorGreen = 137; const int kMouseY = 5; -// Don't analyze begin frames that may be inaccurate. Latencies can be as high +// Don't analyze start frames that may be inaccurate. Latencies can be as high // as 5 frames or so, so skip the first 6 frames to get more accurate results. -const int kIgnoreBeginFrames = 6; +const int kIgnoreStartFrames = 6; // Don't analyze end frames that may be inaccurate. const int kIgnoreEndFrames = 4; // Minimum frames to produce an answer. @@ -478,7 +478,7 @@ double LatencyTest::CalculateLatency() { ++swap_count; // Don't analyze first few swaps, because they are filling the rendering // pipeline and may be unstable. - if (swap_count > kIgnoreBeginFrames) { + if (swap_count > kIgnoreStartFrames) { // First, find the beginning of this swap. size_t begin_swap_pos = 0; EXPECT_TRUE(FindLastOf(events, query_begin_swaps_, end_swap_pos, |