diff options
| author | tony@chromium.org <tony@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-14 01:46:43 +0000 |
|---|---|---|
| committer | tony@chromium.org <tony@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-14 01:46:43 +0000 |
| commit | bcff05af3d60df10a21e07751a14b95ce9e7f3d4 (patch) | |
| tree | 76d8d3ec6c6c0d9564c675d423907e29607bf253 /chrome/test/reliability | |
| parent | 474b2ab8c3b32c07692480aa234f3b2921fe5dd6 (diff) | |
| download | chromium_src-bcff05af3d60df10a21e07751a14b95ce9e7f3d4.zip chromium_src-bcff05af3d60df10a21e07751a14b95ce9e7f3d4.tar.gz chromium_src-bcff05af3d60df10a21e07751a14b95ce9e7f3d4.tar.bz2 | |
Refactor FileVersionInfo into an interface with platform implementations.
This allows us to move the chrome specific version informaton used by
Linux into src/chrome.
Add a GetChromeVersionInfo() for Linux in src/chrome/app/ and make sure to use this in src/chrome.
In src/webkit/glue, add a new glue method for getting the product version. When compiling chrome, use an implementation in src/chrome/renderer (which uses GetChromeVersionInfo()) and a stub implementation for test_shell.
Review URL: http://codereview.chromium.org/1560027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44435 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/reliability')
| -rw-r--r-- | chrome/test/reliability/page_load_test.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/chrome/test/reliability/page_load_test.cc b/chrome/test/reliability/page_load_test.cc index 8d63696..fb673b9 100644 --- a/chrome/test/reliability/page_load_test.cc +++ b/chrome/test/reliability/page_load_test.cc @@ -47,6 +47,7 @@ #include "base/string_util.h" #include "base/test/test_file_util.h" #include "base/time.h" +#include "chrome/app/chrome_version_info.h" #include "chrome/browser/net/url_fixer_upper.h" #include "chrome/browser/pref_service.h" #include "chrome/common/chrome_constants.h" @@ -160,9 +161,10 @@ class PageLoadTest : public UITest { #if defined(OS_WIN) file_info.reset(FileVersionInfo::CreateFileVersionInfo(kChromeDll)); #elif defined(OS_LINUX) || defined(OS_MACOSX) - // TODO(fmeawad): the version retrieved here belongs to the test module and - // not the chrome binary, need to be changed to chrome binary instead. - file_info.reset(FileVersionInfo::CreateFileVersionInfoForCurrentModule()); + // TODO(fmeawad): On Mac, the version retrieved here belongs to the test + // module and not the chrome binary, need to be changed to chrome binary + // instead. + file_info.reset(chrome_app::GetChromeVersionInfo()); #endif // !defined(OS_WIN) std::wstring last_change = file_info->last_change(); test_log << "Last Change: "; |