diff options
| author | jcivelli@google.com <jcivelli@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-26 17:54:08 +0000 |
|---|---|---|
| committer | jcivelli@google.com <jcivelli@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-26 17:54:08 +0000 |
| commit | caf706f870d1d9d576277110ab1df022b2756203 (patch) | |
| tree | 6a890ba2ebeb302c6cdff569d462288a9676d811 /chrome/test/render_view_test.h | |
| parent | 8e23c49777ff4b57fa17f9d5eba8ccd82784e010 (diff) | |
| download | chromium_src-caf706f870d1d9d576277110ab1df022b2756203.zip chromium_src-caf706f870d1d9d576277110ab1df022b2756203.tar.gz chromium_src-caf706f870d1d9d576277110ab1df022b2756203.tar.bz2 | |
Refactoring select popup on Mac.
The select popup on Mac was based on a hack: we would create an invisible RenderWidget and redirect mouse and keyboard events to it and we would display a native Cocoa menu. With this CL we do not use a RenderWidget anymore, we send the user selection to the RenderView which in turns communicates to WebKit that selection.
BUG=None
TEST=On Mac, ensures the select popup works as expected. Also test that for an extension with a browser action containing a select popup, the select popup does work. Also ensures autocomplete/autofill still works (especially popups).
Original review:
http://codereview.chromium.org/3795006/show
Review URL: http://codereview.chromium.org/4078003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63906 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/render_view_test.h')
| -rw-r--r-- | chrome/test/render_view_test.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/chrome/test/render_view_test.h b/chrome/test/render_view_test.h index 1ec224b..bb3e498 100644 --- a/chrome/test/render_view_test.h +++ b/chrome/test/render_view_test.h @@ -48,6 +48,12 @@ class RenderViewTest : public testing::Test { // is a NULL-terminated UTF-8 string. void ExecuteJavaScript(const char* js); + // Executes the given JavaScript and sets the int value it evaluates to in + // |result|. + // Returns true if the JavaScript was evaluated correctly to an int value, + // false otherwise. + bool ExecuteJavaScriptAndReturnIntValue(const string16& script, int* result); + // Loads the given HTML into the main frame as a data: URL. void LoadHTML(const char* html); |