diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-16 08:39:54 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-16 08:39:54 +0000 |
| commit | 6fd3535a1593f4c73c938c7aa7e35eb976ccf280 (patch) | |
| tree | 9a67ff8878ad611c4a35e728a613c451bb25008f /chrome/test/startup | |
| parent | b22b5167bd0a7494a78195d04b5a77ff185de5ae (diff) | |
| download | chromium_src-6fd3535a1593f4c73c938c7aa7e35eb976ccf280.zip chromium_src-6fd3535a1593f4c73c938c7aa7e35eb976ccf280.tar.gz chromium_src-6fd3535a1593f4c73c938c7aa7e35eb976ccf280.tar.bz2 | |
[GTTF] Make automation framework more solid by making sure that
important return values are not ignored.
The macro used here, WARN_UNUSED_RESULT, takes effect only for GCC,
but that's enough since we have bots for all platforms.
Adding these warnings already detected some cases where a return value
was ignored. In some of them the test was trying to get the information
about success "some other way", in some it could sometimes confuse test
failure with test success.
TEST=ui_tests
BUG=none
Review URL: http://codereview.chromium.org/948002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41696 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/startup')
| -rw-r--r-- | chrome/test/startup/feature_startup_test.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/test/startup/feature_startup_test.cc b/chrome/test/startup/feature_startup_test.cc index 31f1b1f..df68386 100644 --- a/chrome/test/startup/feature_startup_test.cc +++ b/chrome/test/startup/feature_startup_test.cc @@ -80,7 +80,7 @@ class NewTabUIStartupTest : public UITest { ASSERT_EQ(1, tab_count); // Hit ctl-t and wait for the tab to load. - window->RunCommand(IDC_NEW_TAB); + ASSERT_TRUE(window->RunCommand(IDC_NEW_TAB)); ASSERT_TRUE(window->GetTabCount(&tab_count)); ASSERT_EQ(2, tab_count); int load_time; @@ -88,7 +88,7 @@ class NewTabUIStartupTest : public UITest { if (want_warm) { // Bring up a second tab, now that we've already shown one tab. - window->RunCommand(IDC_NEW_TAB); + ASSERT_TRUE(window->RunCommand(IDC_NEW_TAB)); ASSERT_TRUE(window->GetTabCount(&tab_count)); ASSERT_EQ(3, tab_count); ASSERT_TRUE(automation()->WaitForInitialNewTabUILoad(&load_time)); @@ -130,7 +130,7 @@ class NewTabUIStartupTest : public UITest { ASSERT_EQ(1, tab_count); // Hit ctl-t and wait for the tab to load. - window->RunCommand(IDC_NEW_TAB); + ASSERT_TRUE(window->RunCommand(IDC_NEW_TAB)); ASSERT_TRUE(window->GetTabCount(&tab_count)); ASSERT_EQ(2, tab_count); int duration; |