diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 19:28:44 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 19:28:44 +0000 |
commit | 528c56de01bbbd38788ed6cf8d2eea4c56cbe19e (patch) | |
tree | ac4f7a001affd772c4ab89701d3d46109b5f9e19 /chrome/test/sync | |
parent | 5c86ada8d84f6e67d17b027d347052ef451241c4 (diff) | |
download | chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.zip chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.tar.gz chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.tar.bz2 |
Move the number conversions from string_util to a new file.
Use the base namespace in the new file. Update callers.
I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling.
TEST=included unit tests
BUG=none
Review URL: http://codereview.chromium.org/3056029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/sync')
-rw-r--r-- | chrome/test/sync/engine/test_id_factory.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/chrome/test/sync/engine/test_id_factory.h b/chrome/test/sync/engine/test_id_factory.h index 70f4bba..9ae0469 100644 --- a/chrome/test/sync/engine/test_id_factory.h +++ b/chrome/test/sync/engine/test_id_factory.h @@ -10,7 +10,7 @@ #include <string> -#include "base/string_util.h" +#include "base/string_number_conversions.h" #include "chrome/browser/sync/syncable/syncable_id.h" namespace browser_sync { @@ -33,9 +33,9 @@ class TestIdFactory { if (value == 0) return root(); else if (value < 0) - return syncable::Id::CreateFromClientString(Int64ToString(value)); + return syncable::Id::CreateFromClientString(base::Int64ToString(value)); else - return syncable::Id::CreateFromServerId(Int64ToString(value)); + return syncable::Id::CreateFromServerId(base::Int64ToString(value)); } // Create a local ID from a name. @@ -51,13 +51,13 @@ class TestIdFactory { // Autogenerate a fresh local ID. syncable::Id NewLocalId() { return syncable::Id::CreateFromClientString( - std::string("_auto ") + IntToString(-next_value())); + std::string("_auto ") + base::IntToString(-next_value())); } // Autogenerate a fresh server ID. syncable::Id NewServerId() { return syncable::Id::CreateFromServerId( - std::string("_auto ") + IntToString(next_value())); + std::string("_auto ") + base::IntToString(next_value())); } private: |