This is the first part of the PageAction implementation. More work is required, but this is a good checkpoint.

Design doc: http://dev.chromium.org/developers/design-documents/extensions/page-actions-api

This checkin only covers Tab scoped page actions (not type "permanent"). It works end to end (if you have an extension that supplies the page action info -- I created an RSS page action that links to Google Reader).

Please note that TabIndex is hard coded to 0 until the extension system can provide the tab id to the extensions (which I understand is in progress). This means that page action(s) only show up for the first tab in the tabstrip. :)

BUG=None
TEST=There is a unit test for the API, but apart from that it is not possible to test this manually without writing an extension that adds a PageAction. My RSS page action is  not ready to be checked in but I can provide it if there is interest in a sneak preview during review/QA.
Review URL: http://codereview.chromium.org/99253

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15105 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 5 deletions

diff --git a/chrome/test/test_location_bar.h b/chrome/test/test_location_bar.h
index 29ba999..f6e94a3 100644
--- a/chrome/test/test_location_bar.h
+++ b/chrome/test/test_location_bar.h
@@ -17,13 +17,13 @@ class TestLocationBar : public LocationBar {
   }
 
   void set_input_string(const std::wstring& input_string) {
-   input_string_ = input_string;
+    input_string_ = input_string;
   }
   void set_disposition(WindowOpenDisposition disposition) {
-   disposition_ = disposition;
+    disposition_ = disposition;
   }
   void set_transition(PageTransition::Type transition) {
-   transition_ = transition;
+    transition_ = transition;
   }
 
   // Overridden from LocationBar:
@@ -34,10 +34,11 @@ class TestLocationBar : public LocationBar {
   }
   virtual PageTransition::Type GetPageTransition() const { return transition_; }
   virtual void AcceptInput() {}
-  virtual void AcceptInputWithDisposition(WindowOpenDisposition) {};
+  virtual void AcceptInputWithDisposition(WindowOpenDisposition) {}
   virtual void FocusLocation() {}
   virtual void FocusSearch() {}
   virtual void UpdateFeedIcon() {}
+  virtual void UpdatePageActions() {}
   virtual void SaveStateToContents(TabContents* contents) {}
 
  private:
@@ -52,4 +53,4 @@ class TestLocationBar : public LocationBar {
 };
 
 
-#endif  // #ifndef CHROME_TEST_TEST_LOCATION_BAR_H_
+#endif  // CHROME_TEST_TEST_LOCATION_BAR_H_