Clean up pref change notification handling.

This is a complete overhaul of PrefValueStore, PrefStore, PrefNotifier, and PrefService. Specifically:

- Add an observer interface to PrefStore that can be used to notify the upper layers of the pref system about value changes. Currently, it's unused mostly, but that'll change when we refactor ExtensionPrefStore and ConfigurationPolicyPrefStore.
- Make PrefNotifier be a dependency of PrefValueStore. That helps in keeping the pref change detection handling local to PrefValueStore.
- Clean up related unit tests, removing redundant mocks and gmockify others.

BUG=64893
TEST=Compiles and passes tests

Review URL: http://codereview.chromium.org/5441002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68574 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 4 insertions, 4 deletions

diff --git a/chrome/test/testing_pref_service.h b/chrome/test/testing_pref_service.h
index 6c60fcf..c5adc021 100644
--- a/chrome/test/testing_pref_service.h
+++ b/chrome/test/testing_pref_service.h
@@ -25,10 +25,10 @@ class TestingPrefService : public PrefService {
   // Create an instance that has a managed PrefStore and a command- line
   // PrefStore. |managed_platform_provider| contains the provider with which to
   // initialize the managed platform PrefStore. If it is NULL, then a
-  // DummyPrefStore will be created. |device_management_provider| contains the
+  // TestingPrefStore will be created. |device_management_provider| contains the
   // provider with which to initialize the device management
   // PrefStore. |command_line| contains the provider with which to initialize
-  // the command line PrefStore. If it is NULL then a DummyPrefStore will be
+  // the command line PrefStore. If it is NULL then a TestingPrefStore will be
   // created as the command line PrefStore.
   TestingPrefService(
       policy::ConfigurationPolicyProvider* managed_platform_provider,
@@ -66,12 +66,12 @@ class TestingPrefService : public PrefService {
 
  private:
   // Creates a ConfigurationPolicyPrefStore based on the provided
-  // |provider| or a DummyPrefStore if |provider| is NULL.
+  // |provider| or a TestingPrefStore if |provider| is NULL.
   PrefStore* CreatePolicyPrefStoreFromProvider(
       policy::ConfigurationPolicyProvider* provider);
 
   // Creates a CommandLinePrefStore based on the supplied
-  // |command_line| or a DummyPrefStore if |command_line| is NULL.
+  // |command_line| or a TestingPrefStore if |command_line| is NULL.
   PrefStore* CreateCommandLinePrefStore(CommandLine* command_line);
 
   // Reads the value of the preference indicated by |path| from |pref_store|.