Adjust preference sync code to only sync user modifiable preferences.

Switch to the new preference value source checkers in Preference. While at it,
add a unit test and better test infrastructure for controlling preference
values in tests. Convert existing unit tests where appropriate.

BUG=48952
TEST=ProfileSyncServicePreferenceTest.ManagedPreferences

Review URL: http://codereview.chromium.org/3051001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53179 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 51 insertions, 0 deletions

diff --git a/chrome/test/testing_pref_service.h b/chrome/test/testing_pref_service.h
new file mode 100644
index 0000000..8155a84
--- /dev/null
+++ b/chrome/test/testing_pref_service.h
@@ -0,0 +1,51 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_TEST_TESTING_PREF_SERVICE_H_
+#define CHROME_TEST_TESTING_PREF_SERVICE_H_
+
+#include <chrome/browser/pref_service.h>
+
+// A PrefService subclass for testing. It operates totally in memory and
+// provides additional API for manipulating preferences at the different levels
+// (managed, extension, user) conveniently.
+class TestingPrefService : public PrefService {
+ public:
+  // Create an empty instance.
+  TestingPrefService();
+
+  // Read the value of a preference from the managed layer. Returns NULL if the
+  // preference is not defined at the managed layer.
+  const Value* GetManagedPref(const wchar_t* path);
+
+  // Set a preference on the managed layer and fire observers if the preference
+  // changed. Assumes ownership of |value|.
+  void SetManagedPref(const wchar_t* path, Value* value);
+
+  // Clear the preference on the managed layer and fire observers if the
+  // preference has been defined previously.
+  void RemoveManagedPref(const wchar_t* path);
+
+  // Similar to the above, but for user preferences.
+  const Value* GetUserPref(const wchar_t* path);
+  void SetUserPref(const wchar_t* path, Value* value);
+  void RemoveUserPref(const wchar_t* path);
+
+ private:
+  // Reads the value of the preference indicated by |path| from |pref_store|.
+  // Returns NULL if the preference was not found.
+  const Value* GetPref(PrefStore* pref_store, const wchar_t* path);
+
+  // Sets the value for |path| in |pref_store|.
+  void SetPref(PrefStore* pref_store, const wchar_t* path, Value* value);
+
+  // Removes the preference identified by |path| from |pref_store|.
+  void RemovePref(PrefStore* pref_store, const wchar_t* path);
+
+  // Pointers to the pref stores our value store uses.
+  PrefStore* managed_prefs_;
+  PrefStore* user_prefs_;
+};
+
+#endif  // CHROME_TEST_TESTING_PREF_SERVICE_H_