diff options
| author | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-20 06:54:36 +0000 |
|---|---|---|
| committer | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-20 06:54:36 +0000 |
| commit | 14908b792cac841803cdc0fa52ef3d7b11e6ff6f (patch) | |
| tree | 97e6bc3a5edaf7dfee73c232b8913ecb9d750b43 /chrome/test/testing_profile.h | |
| parent | 243dff47851291f60ea574c926136932c02e0b15 (diff) | |
| download | chromium_src-14908b792cac841803cdc0fa52ef3d7b11e6ff6f.zip chromium_src-14908b792cac841803cdc0fa52ef3d7b11e6ff6f.tar.gz chromium_src-14908b792cac841803cdc0fa52ef3d7b11e6ff6f.tar.bz2 | |
[Extensions] Make ExtensionService not be ref-counted
Use weak pointers instead, which makes it easier to reason about lifetimes.
Make CrxInstaller et al. use a weak pointer instead.
Add MakeCrxInstaller() function to ExtensionService.
Make WebUI handlers use a raw pointer (since they will always get destroyed
before the profile does).
Make tests use raw or scoped pointers, as appropriate.
Rename extensions_service to extension_service where encountered.
Add checks for BrowserThread::PostTask.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6873065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82257 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/testing_profile.h')
| -rw-r--r-- | chrome/test/testing_profile.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/chrome/test/testing_profile.h b/chrome/test/testing_profile.h index e4a2c25..3e74b92 100644 --- a/chrome/test/testing_profile.h +++ b/chrome/test/testing_profile.h @@ -384,9 +384,7 @@ class TestingProfile : public Profile { // invoked. scoped_ptr<ExtensionPrefs> extension_prefs_; - // For properly notifying the ExtensionService when the profile - // is disposed. - scoped_refptr<ExtensionService> extensions_service_; + scoped_ptr<ExtensionService> extension_service_; scoped_ptr<ExtensionPrefValueMap> extension_pref_value_map_; |