diff options
author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-24 22:05:33 +0000 |
---|---|---|
committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-24 22:05:33 +0000 |
commit | ba66d9e8298ca4237fdf513f3e84233aa6d8152d (patch) | |
tree | 6f81cd2dec16948a2e5d5f3566274a7175d00c95 /chrome/test/testing_profile.h | |
parent | abaf4e6fca4450bb6be70c03fbeb36e33903ad4b (diff) | |
download | chromium_src-ba66d9e8298ca4237fdf513f3e84233aa6d8152d.zip chromium_src-ba66d9e8298ca4237fdf513f3e84233aa6d8152d.tar.gz chromium_src-ba66d9e8298ca4237fdf513f3e84233aa6d8152d.tar.bz2 |
Revert 63687 - Refactors TopSites so that it's hopefully easier to maintain and
doesn't suffer the plethora of threading issues that exist with the
current version. Here's the breakdown of what was refactored:
. TopSitesCache: Contains the most visited urls and thumbnails.
. TopSitesBackend: All mutations to topsites data end up calling into
the backend on the UI thread. TopSitesBackend processes the method on
the DB thread calling through to the TopSitesDatabase.
. TopSites: uses two TopSitesCache. One that contains the raw history
data, the other contains the processed data (pinned/blacklisted). The
processed cache can be accessed on any thread.
TopSites waits until history loads to know if it should migrate or use
it's own db. I could probably make these execute in parallel, but for
now this is how it works.
This patch also makes it so the dom ui accesses the thumbnails on the
IO thread.
BUG=56382
TEST=Make sure all your thumbnails are correctly updated and you don't
see problems.
Review URL: http://codereview.chromium.org/3440018
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/4048005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63695 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/testing_profile.h')
-rw-r--r-- | chrome/test/testing_profile.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/chrome/test/testing_profile.h b/chrome/test/testing_profile.h index c36a5ec..b1395c0 100644 --- a/chrome/test/testing_profile.h +++ b/chrome/test/testing_profile.h @@ -56,8 +56,6 @@ class TestingProfile : public Profile { // for testing error conditions. void CreateHistoryService(bool delete_file, bool no_db); - void CreateTopSites(); - // Creates the BookmkarBarModel. If not invoked the bookmark bar model is // NULL. If |delete_file| is true, the bookmarks file is deleted first, then // the model is created. As TestingProfile deletes the directory containing @@ -82,10 +80,6 @@ class TestingProfile : public Profile { // CreateBookmarkModel. void BlockUntilBookmarkModelLoaded(); - // Blocks until TopSites finishes loading. - void BlockUntilTopSitesLoaded(); - - // Creates a TemplateURLModel. If not invoked the TemplateURLModel is NULL. // Creates a TemplateURLFetcher. If not invoked, the TemplateURLFetcher is // NULL. void CreateTemplateURLFetcher(); |