Moves bookmarks out of history into its own file (JSON).

Interesting points:
. Migration was a bit atypical. Here is the approach I took:
  . If the URL db contains bookmarks it writes the bookmarks to a
    temporary file.
  . When the bookmark bar model is loaded it assumes bookmarks are
    stored in a file. If the bookmarks file doesn't exist it then
    attempts to load from history, after waiting for history to finish
    processing tasks.
. I've broken having the omnibox query for starred only. This patch
  was already too ginormous for me to contemplate this too. I'll return
  to it after I land this.
. Similarly the history page isn't searching for starred titles
  now. As we discussed with Glen, that is probably fine for now.
. I've converted NOTIFY_STARRED_FAVICON_CHANGED to
  NOTIFY_FAVICON_CHANGED and it is notified ANY time a favicon
  changes. I'm mildly concerned about the extra notifications, but
  without having history know about starred it's the best I can do for
  now.
. Autocomplete (specifically URLDatabase::AutocompleteForPrefix)
  previously sorted by starred. It can no longer do this. I don't
  think I can get this functionality back:( Luckily it only mattered
  if you had a starred and non-starred URL with the same type count
  that matched a query. Probably pretty rare.

What's left:
. Fix up HistoryContentsProvider to query for starred entries titles.
. Clean up the delete all case. I basically just made it compile; it
  can be greatly simplified.
. Rename BookmarkBarModel to BookmarksModel.

BUG=1256202
TEST=this is a huge change to bookmarks. Thanfully it's pretty well
  covered by tests, none-the-less make sure you exercise bookmarks
  pretty heavily to make sure nothing is busted.


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1153 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 10 insertions, 4 deletions

diff --git a/chrome/test/testing_profile.h b/chrome/test/testing_profile.h
index 0b30b71..5e89f4a 100644
--- a/chrome/test/testing_profile.h
+++ b/chrome/test/testing_profile.h
@@ -42,11 +42,14 @@
 
 class TestingProfile : public Profile {
  public:
-  TestingProfile() : start_time_(Time::Now()), has_history_service_(false) {}
+  TestingProfile();
   virtual ~TestingProfile();
 
-  // Creates the HistoryService. Normally there is no HistoryService.
-  void CreateHistoryService();
+  // Creates the history service. If |delete_file| is true, the history file is
+  // deleted first, then the HistoryService is created. As TestingProfile
+  // deletes the directory containing the files used by HistoryService, the
+  // boolean only matters if you're recreating the HistoryService.
+  void CreateHistoryService(bool delete_file);
 
   // Creates the BookmkarBarModel. If not invoked the bookmark bar model is
   // NULL.
@@ -56,7 +59,7 @@ class TestingProfile : public Profile {
   void CreateTemplateURLModel();
 
   virtual std::wstring GetPath() {
-    return std::wstring();
+    return path_;
   }
   virtual bool IsOffTheRecord() {
     return false;
@@ -174,6 +177,9 @@ class TestingProfile : public Profile {
 #endif
 
  protected:
+  // The path of the profile; the various database and other files are relative
+  // to this.
+  std::wstring path_;
   Time start_time_;
   ProfileControllerSet controllers_;
   scoped_ptr<PrefService> prefs_;