diff options
author | patrick@chromium.org <patrick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-30 23:28:32 +0000 |
---|---|---|
committer | patrick@chromium.org <patrick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-30 23:28:32 +0000 |
commit | 70e0acd2223d7a2f36aa0552112ed7f80ca32b87 (patch) | |
tree | 9cd51e69703410c5ed905fd7af4f825692cde3d3 /chrome/test/ui/sunspider_uitest.cc | |
parent | 2da8d317072968241f986ffed0be477900831889 (diff) | |
download | chromium_src-70e0acd2223d7a2f36aa0552112ed7f80ca32b87.zip chromium_src-70e0acd2223d7a2f36aa0552112ed7f80ca32b87.tar.gz chromium_src-70e0acd2223d7a2f36aa0552112ed7f80ca32b87.tar.bz2 |
- Add UI test for the V8 Benchmark Suite.
- Modify the V8 Benchmark Suite to work with the UI test framework.
- Add utils for JavaScript UI tests.
- Move automation.js files for SunSpider and V8 Benchmark to the
src/chrome/test/ui directory.
- Overload UITest::PrintResult for convenience.
BUG=9255
Review URL: http://codereview.chromium.org/42628
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12823 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/ui/sunspider_uitest.cc')
-rw-r--r-- | chrome/test/ui/sunspider_uitest.cc | 38 |
1 files changed, 2 insertions, 36 deletions
diff --git a/chrome/test/ui/sunspider_uitest.cc b/chrome/test/ui/sunspider_uitest.cc index 0fe82be..31bb621 100644 --- a/chrome/test/ui/sunspider_uitest.cc +++ b/chrome/test/ui/sunspider_uitest.cc @@ -12,6 +12,7 @@ #include "chrome/common/chrome_switches.h" #include "chrome/common/json_value_serializer.h" #include "chrome/test/automation/tab_proxy.h" +#include "chrome/test/ui/javascript_test_util.h" #include "chrome/test/ui/ui_test.h" #include "googleurl/src/gurl.h" #include "net/base/net_util.h" @@ -91,42 +92,7 @@ class SunSpiderTest : public UITest { return false; std::string json = WideToUTF8(json_wide); - JSONStringValueSerializer deserializer(json); - scoped_ptr<Value> root(deserializer.Deserialize(NULL)); - - EXPECT_TRUE(root.get()); - if (!root.get()) - return false; - - EXPECT_TRUE(root->IsType(Value::TYPE_DICTIONARY)); - if (!root->IsType(Value::TYPE_DICTIONARY)) - return false; - - DictionaryValue* dict = static_cast<DictionaryValue*>(root.get()); - - DictionaryValue::key_iterator it = dict->begin_keys(); - for (; it != dict->end_keys(); ++it) { - Value* value = NULL; - succeeded = dict->Get(*it, &value); - - EXPECT_TRUE(succeeded); - if (!succeeded) - continue; - - EXPECT_TRUE(value->IsType(Value::TYPE_STRING)); - if (value->IsType(Value::TYPE_STRING)) { - std::string key = WideToUTF8(*it); - - std::string result; - succeeded = value->GetAsString(&result); - EXPECT_TRUE(succeeded); - - if (succeeded) - results->insert(std::make_pair(key, result)); - } - } - - return true; + return JsonDictionaryToMap(json, results); } void PrintResults(TabProxy* tab) { |