diff options
author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-06 20:38:23 +0000 |
---|---|---|
committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-06 20:38:23 +0000 |
commit | 7923c790ae1fe65b26cc08bbaf043c28d47e3cc7 (patch) | |
tree | 817dbb9bd8b7c5b6942d67d692a59ef08a33c931 /chrome/test/ui/ui_test.cc | |
parent | 69cd41f227734e0d4bbb11aa1f78add9733ba30d (diff) | |
download | chromium_src-7923c790ae1fe65b26cc08bbaf043c28d47e3cc7.zip chromium_src-7923c790ae1fe65b26cc08bbaf043c28d47e3cc7.tar.gz chromium_src-7923c790ae1fe65b26cc08bbaf043c28d47e3cc7.tar.bz2 |
GTTF: Replace DCHECK with EXPECT_TRUE in UITestBase.
We should avoid crashing entire ui_tests in case of failure.
With EXPECT_TRUE we still see it, but tests continue to run.
TBR=huanr
Review URL: http://codereview.chromium.org/2868116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55279 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/ui/ui_test.cc')
-rw-r--r-- | chrome/test/ui/ui_test.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/test/ui/ui_test.cc b/chrome/test/ui/ui_test.cc index a80718f..59f25bb 100644 --- a/chrome/test/ui/ui_test.cc +++ b/chrome/test/ui/ui_test.cc @@ -890,7 +890,7 @@ bool UITestBase::CloseBrowser(BrowserProxy* browser, if (*application_closed) { // Let's wait until the process dies (if it is not gone already). bool success = base::WaitForSingleProcess(process_, base::kNoTimeout); - DCHECK(success); + EXPECT_TRUE(success); } return result; |