diff options
| author | nirnimesh@chromium.org <nirnimesh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-23 17:14:01 +0000 |
|---|---|---|
| committer | nirnimesh@chromium.org <nirnimesh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-23 17:14:01 +0000 |
| commit | 3f82de6e5ce07ebdb8490fb9cbffb6a0a02ae7a7 (patch) | |
| tree | 08ed6e47882065879d99624c01348fa8f7f046e4 /chrome/test/ui/ui_test.cc | |
| parent | f9204f0406b921905380f7e385bfdd41fb23a401 (diff) | |
| download | chromium_src-3f82de6e5ce07ebdb8490fb9cbffb6a0a02ae7a7.zip chromium_src-3f82de6e5ce07ebdb8490fb9cbffb6a0a02ae7a7.tar.gz chromium_src-3f82de6e5ce07ebdb8490fb9cbffb6a0a02ae7a7.tar.bz2 | |
Fix PyAuto crash when a script has multiple tests.
This CL better maps C++ UITestSuite to python suite and C++ UITestBase
to python testcase. All one-time initializations go in the suite while
testcases are re-entrant now -- this is what fixes the crash.
Also:
- Cmdline flags to pyauto script (verbose, wait for attaching to debugger)
- Establish the setup of sys.path, so that it's setup correctly and tests
don't have to worry about it
- Create facitlites for PYAUTO_TESTS files inside script dirs (say
chrome/test/functional) which defines the tests to run.
- Restructure such that pyauto scripts can be run standalone as well as
using the pyauto.py script (like unittest.py). For example, a test could be
fired in any of the below ways:
# Run tests in a module ('bookmarks')
python pyauto_functional.py bookmarks
# Run tests in a test case ('bookmarks.BookmarksTest')
python pyauto_functional.py bookmarks.BookmarksTest
# Run a test ('bookmarks.BookmarksTest.testBasics')
python pyauto_functional.py bookmarks.BookmarksTest.testBasics
# Run directly from the test script
python bookmarks.py
python bookmarks.py bookmarks
python bookmarks.py bookmarks.BookmarksTest
python bookmarks.py bookmarks.BookmarksTest.testBasics
BUG=32292
TEST=python chrome/test/functional/bookmarks.py
Review URL: http://codereview.chromium.org/1126003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42350 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/ui/ui_test.cc')
| -rw-r--r-- | chrome/test/ui/ui_test.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chrome/test/ui/ui_test.cc b/chrome/test/ui/ui_test.cc index 05d332c..b4ae546 100644 --- a/chrome/test/ui/ui_test.cc +++ b/chrome/test/ui/ui_test.cc @@ -138,7 +138,6 @@ UITestBase::UITestBase(MessageLoop::Type msg_loop_type) enable_file_cookies_(true), profile_type_(UITestBase::DEFAULT_THEME), test_start_time_(base::Time::NowFromSystemTime()), - message_loop_(msg_loop_type), command_execution_timeout_ms_(kCommandExecutionTimeout), action_timeout_ms_(kWaitForActionMsec), action_max_timeout_ms_(kWaitForActionMaxMsec), |