diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-31 17:41:07 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-31 17:41:07 +0000 |
| commit | cb456f494ff09efb876af4850fc0ff7fb8f9c6ac (patch) | |
| tree | 136265f711fe4957df0e30cd7b9b295e5385ac1a /chrome/test/ui/ui_test.h | |
| parent | 8286f51aaab9c769e70a1bcad5c568cec6636ba0 (diff) | |
| download | chromium_src-cb456f494ff09efb876af4850fc0ff7fb8f9c6ac.zip chromium_src-cb456f494ff09efb876af4850fc0ff7fb8f9c6ac.tar.gz chromium_src-cb456f494ff09efb876af4850fc0ff7fb8f9c6ac.tar.bz2 | |
GTTF: Clean up UITest::{Start,Stop}HttpServer:
- On Windows, LaunchAppWithHandleInheritance was not needed,
just LaunchApp is sufficient
- Return values were not checked; I wonder how many of those
resulted in mysterious flaky failures
- Add a scoper object (LayoutTestHttpServer), to make sure
we stop the server even if some other assertions fail.
Note: this change may expose failures that were
silently ingored before. This is a *good* thing.
BUG=none
Review URL: http://codereview.chromium.org/7084038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87320 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/ui/ui_test.h')
| -rw-r--r-- | chrome/test/ui/ui_test.h | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/chrome/test/ui/ui_test.h b/chrome/test/ui/ui_test.h index 85b8215..e6d00c8 100644 --- a/chrome/test/ui/ui_test.h +++ b/chrome/test/ui/ui_test.h @@ -351,14 +351,6 @@ class UITest : public UITestBase, public PlatformTest { virtual ProxyLauncher* CreateProxyLauncher(); - // Synchronously launches local http server normally used to run LayoutTests. - void StartHttpServer(const FilePath& root_directory); - - // Launches local http server on the specified port. - void StartHttpServerWithPort(const FilePath& root_directory, int port); - - void StopHttpServer(); - // Count the number of active browser processes launched by this test. // The count includes browser sub-processes. bool GetBrowserProcessCount(int* count) WARN_UNUSED_RESULT; |