diff options
author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-19 22:37:31 +0000 |
---|---|---|
committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-19 22:37:31 +0000 |
commit | d64295933cbfd3bc984e851412cc79c8a0870acf (patch) | |
tree | 8026b726dc498f4fa6f3e886b1612541ac6f0214 /chrome/test/ui | |
parent | 4f2063cce10295e8b982e98d466c9130d754a540 (diff) | |
download | chromium_src-d64295933cbfd3bc984e851412cc79c8a0870acf.zip chromium_src-d64295933cbfd3bc984e851412cc79c8a0870acf.tar.gz chromium_src-d64295933cbfd3bc984e851412cc79c8a0870acf.tar.bz2 |
Remove action_max_timeout_ms and fix all the callers.
(This was a TODO for phajdan.jr).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6354005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71861 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/ui')
-rw-r--r-- | chrome/test/ui/history_uitest.cc | 19 | ||||
-rw-r--r-- | chrome/test/ui/layout_plugin_uitest.cc | 9 | ||||
-rw-r--r-- | chrome/test/ui/npapi_uitest.cc | 61 | ||||
-rw-r--r-- | chrome/test/ui/omnibox_uitest.cc | 6 | ||||
-rw-r--r-- | chrome/test/ui/pepper_uitest.cc | 5 | ||||
-rw-r--r-- | chrome/test/ui/ppapi_uitest.cc | 4 | ||||
-rw-r--r-- | chrome/test/ui/ui_layout_test.cc | 5 | ||||
-rw-r--r-- | chrome/test/ui/ui_test.h | 3 |
8 files changed, 59 insertions, 53 deletions
diff --git a/chrome/test/ui/history_uitest.cc b/chrome/test/ui/history_uitest.cc index d947dbc7..b8c791b 100644 --- a/chrome/test/ui/history_uitest.cc +++ b/chrome/test/ui/history_uitest.cc @@ -1,10 +1,11 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. // History UI tests #include "base/file_path.h" +#include "base/test/test_timeouts.h" #include "chrome/browser/ui/view_ids.h" #include "chrome/test/automation/browser_proxy.h" #include "chrome/test/automation/tab_proxy.h" @@ -41,7 +42,7 @@ TEST_F(HistoryTester, VerifyHistoryLength1) { GURL url_1 = ui_test_utils::GetTestUrl(FilePath(kHistoryDir), test_case_1); NavigateToURL(url_1); WaitForFinish("History_Length_Test_1", "1", url_1, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } TEST_F(HistoryTester, VerifyHistoryLength2) { @@ -53,7 +54,7 @@ TEST_F(HistoryTester, VerifyHistoryLength2) { GURL url_2 = ui_test_utils::GetTestUrl(FilePath(kHistoryDir), test_case_2); NavigateToURL(url_2); WaitForFinish("History_Length_Test_2", "1", url_2, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } TEST_F(HistoryTester, VerifyHistoryLength3) { @@ -66,21 +67,21 @@ TEST_F(HistoryTester, VerifyHistoryLength3) { GURL url_1 = ui_test_utils::GetTestUrl(FilePath(kHistoryDir), test_case_1); NavigateToURL(url_1); WaitForFinish("History_Length_Test_1", "1", url_1, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); const FilePath test_case_2( FILE_PATH_LITERAL("history_length_test_page_2.html")); GURL url_2 = ui_test_utils::GetTestUrl(FilePath(kHistoryDir), test_case_2); NavigateToURL(url_2); WaitForFinish("History_Length_Test_2", "1", url_2, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); const FilePath test_case_3( FILE_PATH_LITERAL("history_length_test_page_4.html")); GURL url_3 = ui_test_utils::GetTestUrl(FilePath(kHistoryDir), test_case_3); NavigateToURL(url_3); WaitForFinish("History_Length_Test_3", "1", url_3, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } #if defined(OS_WIN) || defined(OS_LINUX) @@ -98,7 +99,7 @@ TEST_F(HistoryTester, ConsiderRedirectAfterGestureAsUserInitiated) { GURL url = ui_test_utils::GetTestUrl(FilePath(kHistoryDir), test_case); NavigateToURL(url); WaitForFinish("History_Length_Test_11", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); // Simulate click. This only works for Windows. scoped_refptr<BrowserProxy> browser = automation()->GetBrowserWindow(0); @@ -114,7 +115,7 @@ TEST_F(HistoryTester, ConsiderRedirectAfterGestureAsUserInitiated) { NavigateToURL(GURL("javascript:redirectToPage12()")); WaitForFinish("History_Length_Test_12", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } #endif // defined(OS_WIN) || defined(OS_LINUX) @@ -132,5 +133,5 @@ TEST_F(HistoryTester, ConsiderSlowRedirectAsUserInitiated) { GURL url = ui_test_utils::GetTestUrl(FilePath(kHistoryDir), test_case); NavigateToURL(url); WaitForFinish("History_Length_Test_21", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } diff --git a/chrome/test/ui/layout_plugin_uitest.cc b/chrome/test/ui/layout_plugin_uitest.cc index 07fab43..0e173f8a 100644 --- a/chrome/test/ui/layout_plugin_uitest.cc +++ b/chrome/test/ui/layout_plugin_uitest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -6,6 +6,7 @@ #include "base/file_path.h" #include "base/path_service.h" +#include "base/test/test_timeouts.h" #include "chrome/common/chrome_paths.h" #include "chrome/common/url_constants.h" #include "chrome/test/ui_test_utils.h" @@ -52,7 +53,7 @@ TEST_F(LayoutPluginTester, FLAKY_SelfDeletePluginGetUrl) { ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("self_delete_plugin_geturl", "1", url, kTestCompleteCookie, kTestCompleteSuccess, - action_max_timeout_ms()); + TestTimeouts::action_max_timeout_ms()); } // Tests if a plugin executing a self deleting script using Invoke @@ -64,7 +65,7 @@ TEST_F(LayoutPluginTester, FLAKY_SelfDeletePluginInvoke) { ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("self_delete_plugin_invoke", "1", url, kTestCompleteCookie, kTestCompleteSuccess, - action_max_timeout_ms()); + TestTimeouts::action_max_timeout_ms()); } TEST_F(LayoutPluginTester, NPObjectReleasedOnDestruction) { @@ -95,5 +96,5 @@ TEST_F(LayoutPluginTester, NPObjectSetException) { ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("npobject_set_exception", "1", url, kTestCompleteCookie, kTestCompleteSuccess, - action_max_timeout_ms()); + TestTimeouts::action_max_timeout_ms()); } diff --git a/chrome/test/ui/npapi_uitest.cc b/chrome/test/ui/npapi_uitest.cc index d85b97d..9bdc0c2 100644 --- a/chrome/test/ui/npapi_uitest.cc +++ b/chrome/test/ui/npapi_uitest.cc @@ -42,7 +42,7 @@ TEST_F(NPAPITesterBase, Arguments) { GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("arguments", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } // Test invoking many plugins within a single page. @@ -53,10 +53,13 @@ TEST_F(NPAPITesterBase, ManyPlugins) { for (int i = 1; i <= 15; i++) { SCOPED_TRACE(StringPrintf("Waiting for plugin #%d", i)); - ASSERT_NO_FATAL_FAILURE(WaitForFinish("arguments", base::IntToString(i), - url, kTestCompleteCookie, - kTestCompleteSuccess, - action_max_timeout_ms())); + ASSERT_NO_FATAL_FAILURE(WaitForFinish( + "arguments", + base::IntToString(i), + url, + kTestCompleteCookie, + kTestCompleteSuccess, + TestTimeouts::action_max_timeout_ms())); } } @@ -66,7 +69,7 @@ TEST_F(NPAPITesterBase, GetURL) { GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("geturl", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } // Test various calls to GetURL for javascript URLs with @@ -76,7 +79,7 @@ TEST_F(NPAPITesterBase, GetJavaScriptURL) { GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("getjavascripturl", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } // Test that calling GetURL with a javascript URL and target=_self @@ -86,7 +89,7 @@ TEST_F(NPAPITesterBase, GetJavaScriptURL2) { GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("getjavascripturl2", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } TEST_F(NPAPITesterBase, GetURLRedirectNotification) { @@ -94,7 +97,7 @@ TEST_F(NPAPITesterBase, GetURLRedirectNotification) { GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("geturlredirectnotify", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } // Tests that if an NPObject is proxies back to its original process, the @@ -105,7 +108,7 @@ TEST_F(NPAPITesterBase, NPObjectProxy) { GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("npobject_proxy", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } #if defined(OS_WIN) || defined(OS_MACOSX) @@ -124,7 +127,7 @@ TEST_F(NPAPIVisiblePluginTester, ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("execute_script_delete_in_paint", "1", url, kTestCompleteCookie, kTestCompleteSuccess, - action_max_timeout_ms()); + TestTimeouts::action_max_timeout_ms()); } #endif @@ -138,7 +141,7 @@ TEST_F(NPAPIVisiblePluginTester, SelfDeletePluginInNewStream) { ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("self_delete_plugin_stream", "1", url, kTestCompleteCookie, kTestCompleteSuccess, - action_max_timeout_ms()); + TestTimeouts::action_max_timeout_ms()); } #if defined(OS_WIN) @@ -149,7 +152,7 @@ TEST_F(NPAPIVisiblePluginTester, VerifyPluginWindowRect) { GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("checkwindowrect", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } // Tests that creating a new instance of a plugin while another one is handling @@ -160,7 +163,7 @@ TEST_F(NPAPIVisiblePluginTester, CreateInstanceInPaint) { GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("create_instance_in_paint", "2", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } // Tests that putting up an alert in response to a paint doesn't deadlock. @@ -200,7 +203,7 @@ TEST_F(NPAPIVisiblePluginTester, VerifyNPObjectLifetimeTest) { ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("npobject_lifetime_test", "1", url, kTestCompleteCookie, kTestCompleteSuccess, - action_max_timeout_ms()); + TestTimeouts::action_max_timeout_ms()); } // Tests that we don't crash or assert if NPP_New fails @@ -209,7 +212,7 @@ TEST_F(NPAPIVisiblePluginTester, NewFails) { GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("new_fails", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } TEST_F(NPAPIVisiblePluginTester, SelfDeletePluginInNPNEvaluate) { @@ -222,7 +225,7 @@ TEST_F(NPAPIVisiblePluginTester, SelfDeletePluginInNPNEvaluate) { ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("npobject_delete_plugin_in_evaluate", "1", url, kTestCompleteCookie, kTestCompleteSuccess, - action_max_timeout_ms()); + TestTimeouts::action_max_timeout_ms()); } TEST_F(NPAPIVisiblePluginTester, SelfDeleteCreatePluginInNPNEvaluate) { @@ -235,7 +238,7 @@ TEST_F(NPAPIVisiblePluginTester, SelfDeleteCreatePluginInNPNEvaluate) { ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("npobject_delete_create_plugin_in_evaluate", "1", url, kTestCompleteCookie, kTestCompleteSuccess, - action_max_timeout_ms()); + TestTimeouts::action_max_timeout_ms()); } #endif @@ -265,7 +268,7 @@ TEST_F(NPAPITesterBase, PrivateDisabled) { GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("private", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } TEST_F(NPAPITesterBase, ScheduleTimer) { @@ -273,7 +276,7 @@ TEST_F(NPAPITesterBase, ScheduleTimer) { GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("schedule_timer", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } TEST_F(NPAPITesterBase, PluginThreadAsyncCall) { @@ -281,7 +284,7 @@ TEST_F(NPAPITesterBase, PluginThreadAsyncCall) { GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("plugin_thread_async_call", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } // Test checking the privacy mode is on. @@ -293,7 +296,7 @@ TEST_F(NPAPIIncognitoTester, PrivateEnabled) { GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("private", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } #if defined(OS_WIN) || defined(OS_MACOSX) @@ -308,7 +311,7 @@ TEST_F(NPAPIVisiblePluginTester, MultipleInstancesSyncCalls) { GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("multiple_instances_sync_calls", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } #endif @@ -323,7 +326,7 @@ TEST_F(NPAPIVisiblePluginTester, GetURLRequestFailWrite) { ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("geturl_fail_write", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } #if defined(OS_WIN) @@ -337,7 +340,7 @@ TEST_F(NPAPITesterBase, EnsureScriptingWorksInDestroy) { ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("ensure_scripting_works_in_destroy", "1", url, kTestCompleteCookie, kTestCompleteSuccess, - action_max_timeout_ms()); + TestTimeouts::action_max_timeout_ms()); } // This test uses a Windows Event to signal to the plugin that it should crash @@ -358,7 +361,7 @@ TEST_F(NPAPITesterBase, NoHangIfInitCrashes) { NavigateToURL(url); WaitForFinish("no_hang_if_init_crashes", "1", url, kTestCompleteCookie, kTestCompleteSuccess, - action_max_timeout_ms()); + TestTimeouts::action_max_timeout_ms()); CloseHandle(crash_event); } @@ -375,7 +378,7 @@ TEST_F(NPAPIVisiblePluginTester, PluginReferrerTest) { ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("plugin_referrer_test", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } #if defined(OS_MACOSX) @@ -397,7 +400,7 @@ TEST_F(NPAPIVisiblePluginTester, PluginConvertPointTest) { // change the test to trigger on mouse-down rather than window focus. ASSERT_TRUE(browser->BringToFront()); WaitForFinish("convert_point", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } #endif @@ -417,5 +420,5 @@ TEST_F(NPAPIVisiblePluginTester, ClickToPlay) { ASSERT_TRUE(tab->LoadBlockedPlugins()); WaitForFinish("setup", "1", url, kTestCompleteCookie, - kTestCompleteSuccess, action_max_timeout_ms()); + kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); } diff --git a/chrome/test/ui/omnibox_uitest.cc b/chrome/test/ui/omnibox_uitest.cc index 86016bde..b30f91d 100644 --- a/chrome/test/ui/omnibox_uitest.cc +++ b/chrome/test/ui/omnibox_uitest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -10,6 +10,7 @@ #include "base/path_service.h" #include "base/perftimer.h" #include "base/string_util.h" +#include "base/test/test_timeouts.h" #include "base/utf_string_conversions.h" #include "chrome/app/chrome_command_ids.h" #include "chrome/common/chrome_paths.h" @@ -93,7 +94,8 @@ void OmniboxTest::RunQueryChain(const std::wstring& input_text) { // matches to be returned to us. ASSERT_TRUE(autocomplete_edit->SetText(input_text.substr(0, i))); PerfTimer timer; - if (autocomplete_edit->WaitForQuery(action_max_timeout_ms())) { + if (autocomplete_edit->WaitForQuery( + TestTimeouts::action_max_timeout_ms())) { ASSERT_TRUE(autocomplete_edit->GetAutocompleteMatches(&matches)); int64 time_elapsed = timer.Elapsed().InMilliseconds(); diff --git a/chrome/test/ui/pepper_uitest.cc b/chrome/test/ui/pepper_uitest.cc index 590b5f3..f34346d 100644 --- a/chrome/test/ui/pepper_uitest.cc +++ b/chrome/test/ui/pepper_uitest.cc @@ -1,10 +1,11 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include "base/file_path.h" #include "app/app_switches.h" +#include "base/test/test_timeouts.h" #include "chrome/common/chrome_switches.h" #include "chrome/test/ui/npapi_test_helper.h" #include "chrome/test/ui_test_utils.h" @@ -41,6 +42,6 @@ TEST_F(PepperTester, FAILS_Pepper3D) { ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); WaitForFinish("pepper_3d", "1", url, kTestCompleteCookie, kTestCompleteSuccess, - action_max_timeout_ms()); + TestTimeouts::action_max_timeout_ms()); } #endif diff --git a/chrome/test/ui/ppapi_uitest.cc b/chrome/test/ui/ppapi_uitest.cc index 911018a..3a5e304 100644 --- a/chrome/test/ui/ppapi_uitest.cc +++ b/chrome/test/ui/ppapi_uitest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -93,7 +93,7 @@ class PPAPITest : public UITest { // making sure we're making forward progress. std::string startup_cookie = WaitUntilCookieNonEmpty(tab.get(), test_url, - "STARTUP_COOKIE", action_max_timeout_ms()); + "STARTUP_COOKIE", TestTimeouts::action_max_timeout_ms()); // If this fails, the plugin couldn't be loaded in the given amount of // time. This may mean the plugin was not found or possibly the system diff --git a/chrome/test/ui/ui_layout_test.cc b/chrome/test/ui/ui_layout_test.cc index a4dffc9..ca55578 100644 --- a/chrome/test/ui/ui_layout_test.cc +++ b/chrome/test/ui/ui_layout_test.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -8,6 +8,7 @@ #include "base/path_service.h" #include "base/string_number_conversions.h" #include "base/test/test_file_util.h" +#include "base/test/test_timeouts.h" #include "base/utf_string_conversions.h" #include "chrome/common/chrome_paths.h" #include "chrome/test/automation/tab_proxy.h" @@ -220,7 +221,7 @@ void UILayoutTest::RunLayoutTest(const std::string& test_case_file_name, ASSERT_TRUE(tab->NavigateToURL(*new_test_url.get())); std::string escaped_value = WaitUntilCookieNonEmpty(tab.get(), *new_test_url.get(), - status_cookie.c_str(), action_max_timeout_ms()); + status_cookie.c_str(), TestTimeouts::action_max_timeout_ms()); // Unescapes and normalizes the actual result. std::string value = UnescapeURLComponent(escaped_value, diff --git a/chrome/test/ui/ui_test.h b/chrome/test/ui/ui_test.h index c248d0d..55763c9 100644 --- a/chrome/test/ui/ui_test.h +++ b/chrome/test/ui/ui_test.h @@ -249,9 +249,6 @@ class UITestBase { static int command_execution_timeout_ms() { return TestTimeouts::command_execution_timeout_ms(); } - static int action_max_timeout_ms() { - return TestTimeouts::action_max_timeout_ms(); - } // Fetch the state which determines whether the profile will be cleared on // next startup. |