diff options
author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-25 20:05:45 +0000 |
---|---|---|
committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-25 20:05:45 +0000 |
commit | eab113f82537b904c52912663d625cb6afefa3b0 (patch) | |
tree | 28a488f33fb0f162aa1c1e6b99f20cfc54424bce /chrome/test/ui | |
parent | 5fe90ea611c57e45d82b1982e600f9d6ca142a98 (diff) | |
download | chromium_src-eab113f82537b904c52912663d625cb6afefa3b0.zip chromium_src-eab113f82537b904c52912663d625cb6afefa3b0.tar.gz chromium_src-eab113f82537b904c52912663d625cb6afefa3b0.tar.bz2 |
Revert 24266 - This CL ensures that plugins always peek in the context of outgoing sync calls.
I will be watching the reliability test runs closely for any crashes which creep in due to reentrancies into plugins caused by this CL.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=15985
It is a touch tricky to implement a test case for this. Will add one hopefully in a subsequent CL
Bug=15985
Test=Covered by UI test
Review URL: http://codereview.chromium.org/173211
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/173384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24296 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/ui')
-rw-r--r-- | chrome/test/ui/npapi_uitest.cc | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/chrome/test/ui/npapi_uitest.cc b/chrome/test/ui/npapi_uitest.cc index a4fa299..eb19042 100644 --- a/chrome/test/ui/npapi_uitest.cc +++ b/chrome/test/ui/npapi_uitest.cc @@ -298,13 +298,3 @@ TEST_F(NPAPIVisiblePluginTester, MultipleInstancesSyncCalls) { kTestCompleteSuccess, kShortWaitTimeout); } -TEST_F(NPAPIVisiblePluginTester, EnsurePluginsPumpInSyncCalls) { - if (UITest::in_process_renderer()) - return; - - GURL url = GetTestUrl(L"npapi", - L"ensure_plugins_pump_messages_in_sync_calls.html"); - NavigateToURL(url); - WaitForFinish("src_plugin_for_outgoing_sync_call", "1", url, - kTestCompleteCookie, kTestCompleteSuccess, kShortWaitTimeout); -} |