diff options
author | mirandac@chromium.org <mirandac@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-15 16:33:42 +0000 |
---|---|---|
committer | mirandac@chromium.org <mirandac@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-15 16:33:42 +0000 |
commit | 3e9996e8b7f2e53c71a205852feeb16012ad43e5 (patch) | |
tree | f774509571cc7f8beb28476ada1f3b763646d2c1 /chrome/test/ui | |
parent | 98a4a3ec81fc455480e745cb32e94fa2c4f904a6 (diff) | |
download | chromium_src-3e9996e8b7f2e53c71a205852feeb16012ad43e5.zip chromium_src-3e9996e8b7f2e53c71a205852feeb16012ad43e5.tar.gz chromium_src-3e9996e8b7f2e53c71a205852feeb16012ad43e5.tar.bz2 |
Fix startup tests with complex theme.
BUG= http://crbug.com/18767
TEST= none
Review URL: http://codereview.chromium.org/165478
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23524 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/ui')
-rw-r--r-- | chrome/test/ui/ui_test.cc | 40 | ||||
-rw-r--r-- | chrome/test/ui/ui_test.h | 5 |
2 files changed, 44 insertions, 1 deletions
diff --git a/chrome/test/ui/ui_test.cc b/chrome/test/ui/ui_test.cc index 69de19a..cc768e9 100644 --- a/chrome/test/ui/ui_test.cc +++ b/chrome/test/ui/ui_test.cc @@ -97,6 +97,7 @@ UITest::UITest() include_testing_id_(true), use_existing_browser_(default_use_existing_browser_), enable_file_cookies_(true), + profile_type_(UITest::DEFAULT_THEME), test_start_time_(base::Time::NowFromSystemTime()), command_execution_timeout_ms_(kMaxTestExecutionTime), action_timeout_ms_(kWaitForActionMsec), @@ -307,7 +308,7 @@ void UITest::LaunchBrowser(const CommandLine& arguments, bool clear_profile) { chrome::kBrowserProcessExecutablePath)); CommandLine command_line(command.ToWStringHack()); - // Add any explict command line flags passed to the process. + // Add any explicit command line flags passed to the process. std::wstring extra_chrome_flags = CommandLine::ForCurrentProcess()->GetSwitchValue(kExtraChromeFlagsSwitch); if (!extra_chrome_flags.empty()) { @@ -423,6 +424,11 @@ void UITest::LaunchBrowser(const CommandLine& arguments, bool clear_profile) { ASSERT_TRUE(file_util::CopyRecursiveDirNoCache( template_user_data_, user_data_dir_.ToWStringHack())); + // If we're using the complex theme data, we need to write the + // user_data_dir_ to our preferences file. + if (profile_type_ == UITest::COMPLEX_THEME) { + RewritePreferencesFile(user_data_dir_); + } } browser_launch_time_ = TimeTicks::Now(); @@ -965,6 +971,38 @@ bool UITest::EvictFileFromSystemCacheWrapper(const FilePath& path) { } // static +void UITest::RewritePreferencesFile(const FilePath& user_data_dir) { + const FilePath pref_template_path( + user_data_dir.AppendASCII("Default").AppendASCII("PreferencesTemplate")); + const FilePath pref_path( + user_data_dir.AppendASCII("Default").AppendASCII("Preferences")); + + // Read in preferences template. + std::string pref_string; + EXPECT_TRUE(file_util::ReadFileToString(pref_template_path, &pref_string)); + string16 format_string = ASCIIToUTF16(pref_string); + + // Make sure temp directory has the proper format for writing to prefs file. +#if defined(OS_POSIX) + std::wstring user_data_dir_w(ASCIIToWide(user_data_dir.value())); +#elif defined(OS_WIN) + std::wstring user_data_dir_w(user_data_dir.value()); + // In Windows, the FilePath will write '\' for the path separators; change + // these to a separator that won't trigger escapes. + std::replace(user_data_dir_w.begin(), + user_data_dir_w.end(), '\\', '/'); +#endif + + // Rewrite prefs file. + std::vector<string16> subst; + subst.push_back(WideToUTF16(user_data_dir_w)); + const std::string prefs_string = + UTF16ToASCII(ReplaceStringPlaceholders(format_string, subst, NULL)); + EXPECT_TRUE(file_util::WriteFile(pref_path, prefs_string.c_str(), + prefs_string.size())); +} + +// static FilePath UITest::ComputeTypicalUserDataSource(int profile_type) { FilePath source_history_file; EXPECT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, diff --git a/chrome/test/ui/ui_test.h b/chrome/test/ui/ui_test.h index a512fb7..2b49f82 100644 --- a/chrome/test/ui/ui_test.h +++ b/chrome/test/ui/ui_test.h @@ -342,6 +342,9 @@ class UITest : public testing::Test { // for testing. static FilePath ComputeTypicalUserDataSource(int profile_type); + // Rewrite the preferences file to point to the proper image directory. + static void RewritePreferencesFile(const FilePath& user_data_dir); + // Called by some tests that wish to have a base profile to start from. This // "user data directory" (containing one or more profiles) will be recursively // copied into the user data directory for the test and the files will be @@ -479,6 +482,8 @@ class UITest : public testing::Test { bool use_existing_browser_; // Duplicate of the static version. // Default value comes from static. bool enable_file_cookies_; // Enable file cookies, default is true. + int profile_type_; // Are we using a profile with a + // complex theme? private: base::Time test_start_time_; // Time the test was started |