diff options
author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-01 14:54:54 +0000 |
---|---|---|
committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-01 14:54:54 +0000 |
commit | 1b8b17cc6c94289ae75ad035db84d309739aba19 (patch) | |
tree | cd6f6de35906a526e532306934e626de9e874d44 /chrome/test/ui_test_utils.cc | |
parent | e14f9533b3b73f2c23338acf9fda7a92c691df12 (diff) | |
download | chromium_src-1b8b17cc6c94289ae75ad035db84d309739aba19.zip chromium_src-1b8b17cc6c94289ae75ad035db84d309739aba19.tar.gz chromium_src-1b8b17cc6c94289ae75ad035db84d309739aba19.tar.bz2 |
Figure out error in test PrepopulateRespectBlank.
Revert previous traces and add one targeted test.
My traces seem to indicate that something else
than a Chrome window has focus when the test fails.
Lets figure out what that is...
BUG=62937
TEST=Tracking down problem in test
Review URL: http://codereview.chromium.org/5463001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67849 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/ui_test_utils.cc')
-rw-r--r-- | chrome/test/ui_test_utils.cc | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/chrome/test/ui_test_utils.cc b/chrome/test/ui_test_utils.cc index b7db307..d6310f3 100644 --- a/chrome/test/ui_test_utils.cc +++ b/chrome/test/ui_test_utils.cc @@ -341,12 +341,6 @@ bool ExecuteJavaScriptHelper(RenderViewHost* render_view_host, return true; } -void Checkpoint(const char* message, const base::TimeTicks& start_time) { - LOG(INFO) << message << " : " - << (base::TimeTicks::Now() - start_time).InMilliseconds() - << " ms" << std::flush; -} - } // namespace void RunMessageLoop() { @@ -612,13 +606,11 @@ bool SendKeyPressSync(const Browser* browser, bool alt, bool command) { base::TimeTicks start_time = base::TimeTicks::Now(); - Checkpoint("SendKeyPressSync", start_time); gfx::NativeWindow window = NULL; if (!GetNativeWindow(browser, &window)) return false; - Checkpoint("SendKeyPressNotifyWhenDone", start_time); if (!ui_controls::SendKeyPressNotifyWhenDone( window, key, control, shift, alt, command, new MessageLoop::QuitTask())) { @@ -628,9 +620,7 @@ bool SendKeyPressSync(const Browser* browser, // Run the message loop. It'll stop running when either the key was received // or the test timed out (in which case testing::Test::HasFatalFailure should // be set). - Checkpoint("Running loop", start_time); RunMessageLoop(); - Checkpoint("Check if HasFatalFailure", start_time); return !testing::Test::HasFatalFailure(); } |