diff options
| author | rdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-19 17:03:29 +0000 |
|---|---|---|
| committer | rdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-19 17:03:29 +0000 |
| commit | 488379666f4234033e4cf8c78bd4db6c23f07c07 (patch) | |
| tree | 8bc64e6cf78e24f69d0f5fc6b99b7ff132c39de7 /chrome/test/ui_test_utils.cc | |
| parent | a77442aa7661a12c940144d99a8c025442b7e894 (diff) | |
| download | chromium_src-488379666f4234033e4cf8c78bd4db6c23f07c07.zip chromium_src-488379666f4234033e4cf8c78bd4db6c23f07c07.tar.gz chromium_src-488379666f4234033e4cf8c78bd4db6c23f07c07.tar.bz2 | |
New cancel test (includes change in DownloadItem::Complete meaning and
notification interface).
* Changed DownloadItem::COMPLETE state to mean "really all done" with download (used to mean "all data received"). This isn't a very large change, since we recently put in another change to dangerous downloads where we didn't recognize all data received until we had been accepted by the user, which means that there aren't any blocking points between all data received and COMPLETE.
* Removed DownloadItem::Observer::OnDownloadFileCompleted() notification. It's now redundant with the COMPLETE state, and the COMPLETE state works better for synchronization (because you can test the download item for it as opposed to having to be an observer when the notification is sent).
* Added a basic test for cancel functionality in the downloads system.
Also shifted MarkAsComplete to be used only by SavePackage, and make sure that the final transition occurs for drag-n-drop downloads (which don't need to go through name finalization).
BUG=78183
TEST=All known download tests, manual drag-and-drop and dangerous accept/discard pre/post data received.
Review URL: http://codereview.chromium.org/6720061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82113 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/ui_test_utils.cc')
| -rw-r--r-- | chrome/test/ui_test_utils.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chrome/test/ui_test_utils.cc b/chrome/test/ui_test_utils.cc index b58eea9..6ab4429 100644 --- a/chrome/test/ui_test_utils.cc +++ b/chrome/test/ui_test_utils.cc @@ -207,7 +207,6 @@ class DownloadsCompleteObserver : public DownloadManager::Observer, CheckAllDownloadsComplete(); } - virtual void OnDownloadFileCompleted(DownloadItem* download) { } virtual void OnDownloadOpened(DownloadItem* download) {} // DownloadManager::Observer |