diff options
| author | brettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-15 20:10:49 +0000 |
|---|---|---|
| committer | brettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-15 20:10:49 +0000 |
| commit | 849890b62b75f95cf91ebd3fe49f1525ff6595bd (patch) | |
| tree | d41eef8bb5a3e52ef3a8e356d08d99dd3baacd9f /chrome/test/unit | |
| parent | 3a453fa1f16dfa4168e52790e329148366abb05f (diff) | |
| download | chromium_src-849890b62b75f95cf91ebd3fe49f1525ff6595bd.zip chromium_src-849890b62b75f95cf91ebd3fe49f1525ff6595bd.tar.gz chromium_src-849890b62b75f95cf91ebd3fe49f1525ff6595bd.tar.bz2 | |
Cleans up notifications for the NavigationController. There were several
notifications before and some of them were very unclear and misused
(STATE_CHANGED). This one, and PRUNED were called unnecessarily in some cases
as well.
I replaced STATE_CHANGED and INDEX_CHANGED with ENTRY_COMMITTED which is more
clear and covers (I think!) all the cases that the callers care about.
I added a simple notification testing helper class, and used in the navigation
controller unit tests to make sure we get the proper notifications. I had to
change NotificationSource/Details to have a = and copy constructor so I can
track them easily in my helper. I don't see why this would be bad.
As part of this, I got very frustrated recompiling the world whenever
navigation_types.h changed. So I removed this dependency from the notification
service which everybody includes. Most of the changed files are adding
notification_types.h in the .cc file where it's needed.
BUG=1325636,1321376,1325779
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@956 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/unit')
| -rw-r--r-- | chrome/test/unit/unittests.vcproj | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/chrome/test/unit/unittests.vcproj b/chrome/test/unit/unittests.vcproj index 9aa1c90..ee496de 100644 --- a/chrome/test/unit/unittests.vcproj +++ b/chrome/test/unit/unittests.vcproj @@ -182,6 +182,14 @@ > </File> <File + RelativePath="..\test_notification_tracker.cc" + > + </File> + <File + RelativePath="..\test_notification_tracker.h" + > + </File> + <File RelativePath="..\testing_browser_process.h" > </File> @@ -194,19 +202,19 @@ > </File> <File - RelativePath="..\ui\view_event_test_base.cc" + RelativePath="..\..\..\net\url_request\url_request_test_job.cc" > </File> <File - RelativePath="..\ui\view_event_test_base.h" + RelativePath="..\..\..\net\url_request\url_request_test_job.h" > </File> <File - RelativePath="..\..\..\net\url_request\url_request_test_job.cc" + RelativePath="..\ui\view_event_test_base.cc" > </File> <File - RelativePath="..\..\..\net\url_request\url_request_test_job.h" + RelativePath="..\ui\view_event_test_base.h" > </File> </Filter> |