diff options
author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-20 20:22:07 +0000 |
---|---|---|
committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-20 20:22:07 +0000 |
commit | ca8cf5f8032626708e47604d190dbda0ffd8d618 (patch) | |
tree | 4a73ad587be839680e0e0b879ef664558bf3a87a /chrome/test/webdriver/utility_functions.cc | |
parent | 593df619ff5c865bea2ffdd8927e5462c91318a2 (diff) | |
download | chromium_src-ca8cf5f8032626708e47604d190dbda0ffd8d618.zip chromium_src-ca8cf5f8032626708e47604d190dbda0ffd8d618.tar.gz chromium_src-ca8cf5f8032626708e47604d190dbda0ffd8d618.tar.bz2 |
Convert LOG(INFO) to VLOG(1) - chrome/test/.
Also fix indentation, remove a few unnecessary endls, collapse some append()s into +s, and remove a few extra {}s.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3915004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63253 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/webdriver/utility_functions.cc')
-rw-r--r-- | chrome/test/webdriver/utility_functions.cc | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/chrome/test/webdriver/utility_functions.cc b/chrome/test/webdriver/utility_functions.cc index 6744e67..54e5ae8 100644 --- a/chrome/test/webdriver/utility_functions.cc +++ b/chrome/test/webdriver/utility_functions.cc @@ -21,9 +21,8 @@ std::wstring build_atom(const wchar_t* const atom[], const size_t& size) { const size_t len = size / sizeof(atom[0]); std::wstring ret = L""; for (size_t i = 0; i < len; ++i) { - if (atom[i] != NULL) { + if (atom[i] != NULL) ret.append(std::wstring(atom[i])); - } } return ret; } @@ -65,19 +64,17 @@ bool ParseJSONDictionary(const std::string& json, DictionaryValue** dict, Value* params = base::JSONReader::ReadAndReturnError(json, true, &error_code, error); if (error_code != 0) { - LOG(INFO) << "Could not parse JSON object, " << *error << std::endl; - if (params) { + VLOG(1) << "Could not parse JSON object, " << *error; + if (params) delete params; - } return false; } if (!params || params->GetType() != Value::TYPE_DICTIONARY) { *error = "Data passed in URL must be of type dictionary."; - LOG(INFO) << "Invalid type to parse" << std::endl; - if (params) { + VLOG(1) << "Invalid type to parse"; + if (params) delete params; - } return false; } |