diff options
| author | rsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-08 19:25:28 +0000 |
|---|---|---|
| committer | rsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-08 19:25:28 +0000 |
| commit | 33cd0041d46c0593dfb90a87e861ca47976fab49 (patch) | |
| tree | 2f3328ddf8d1044211943564e12348b7224afd72 /chrome/test | |
| parent | 1ce52aae084f6a0201c64141e35772fc70bab1f0 (diff) | |
| download | chromium_src-33cd0041d46c0593dfb90a87e861ca47976fab49.zip chromium_src-33cd0041d46c0593dfb90a87e861ca47976fab49.tar.gz chromium_src-33cd0041d46c0593dfb90a87e861ca47976fab49.tar.bz2 | |
Adding the sync-notification-host command line parameter to the integration tests.
The sync integration tests currently access the network to communicate
with the notification server. We need to move to a model where all
server accesses are stubbed out by local servers. This is the first step
towards implementing a local notification server.
BUG=53933,53931
TEST=sync_integration_tests
First time committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58768
Review URL: http://codereview.chromium.org/3326007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58860 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test')
| -rw-r--r-- | chrome/test/live_sync/live_sync_test.cc | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/chrome/test/live_sync/live_sync_test.cc b/chrome/test/live_sync/live_sync_test.cc index 5ff3e74..5191855 100644 --- a/chrome/test/live_sync/live_sync_test.cc +++ b/chrome/test/live_sync/live_sync_test.cc @@ -123,6 +123,8 @@ void LiveSyncTest::SetUp() { "transitional"); } + // TODO(akalin): Delete this block of code once a local python notification + // server is implemented. // The chrome sync builders are behind a firewall that blocks port 5222, the // default port for XMPP notifications. This causes the tests to spend up to a // minute waiting for a connection on port 5222 before they fail over to port @@ -249,6 +251,9 @@ void LiveSyncTest::SetUpLocalTestServer() { StringPrintf("http://%s:%d/chromiumsync", test_server_.host_port_pair().host().c_str(), test_server_.host_port_pair().port())); + + // TODO(akalin): Set the kSyncNotificationHost switch here once a local python + // notification server is implemented. } void LiveSyncTest::TearDownLocalTestServer() { |