diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-23 01:48:58 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-23 01:48:58 +0000 |
| commit | a26dc3692818f34a1bb5341931ac2cd26819bb09 (patch) | |
| tree | c77abccac30298c0d1b55991321466610fb9e15c /chrome/test | |
| parent | ce53c9e6d9b9211f853e0d6f426a12b0bab6a875 (diff) | |
| download | chromium_src-a26dc3692818f34a1bb5341931ac2cd26819bb09.zip chromium_src-a26dc3692818f34a1bb5341931ac2cd26819bb09.tar.gz chromium_src-a26dc3692818f34a1bb5341931ac2cd26819bb09.tar.bz2 | |
Don't select all when autofocusing the location bar on New Tab creation. Users could already be typing in the omnibox before the load commits (e.g. due to a slow renderer process startup) and this typing would then be selected and overwritten.
BUG=41466
TEST=On a very slow machine, typing before a new tab finishes loading should not be selected or cleared once the tab finishes loading.
Review URL: http://codereview.chromium.org/1738004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45406 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test')
| -rw-r--r-- | chrome/test/test_browser_window.h | 2 | ||||
| -rw-r--r-- | chrome/test/test_location_bar.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/chrome/test/test_browser_window.h b/chrome/test/test_browser_window.h index c81ff1c..9f384f6 100644 --- a/chrome/test/test_browser_window.h +++ b/chrome/test/test_browser_window.h @@ -43,7 +43,7 @@ class TestBrowserWindow : public BrowserWindow { virtual LocationBar* GetLocationBar() const { return const_cast<TestLocationBar*>(&location_bar_); } - virtual void SetFocusToLocationBar() {} + virtual void SetFocusToLocationBar(bool select_all) {} virtual void UpdateStopGoState(bool is_loading, bool force) {} virtual void UpdateToolbar(TabContents* contents, bool should_restore_state) {} diff --git a/chrome/test/test_location_bar.h b/chrome/test/test_location_bar.h index 7d4a114..2c06329 100644 --- a/chrome/test/test_location_bar.h +++ b/chrome/test/test_location_bar.h @@ -36,7 +36,7 @@ class TestLocationBar : public LocationBar { virtual PageTransition::Type GetPageTransition() const { return transition_; } virtual void AcceptInput() {} virtual void AcceptInputWithDisposition(WindowOpenDisposition) {} - virtual void FocusLocation() {} + virtual void FocusLocation(bool select_all) {} virtual void FocusSearch() {} virtual void UpdateContentSettingsIcons() {} virtual void UpdatePageActions() {} |