diff options
author | nirnimesh@chromium.org <nirnimesh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-09 18:10:25 +0000 |
---|---|---|
committer | nirnimesh@chromium.org <nirnimesh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-09 18:10:25 +0000 |
commit | 2e981ac35da47f84ee5a197e4a54a9f69a3b825d (patch) | |
tree | e69d3b06a1a4cfd474a3fbc98ffb2085822e9f1f /chrome/test | |
parent | a677692d41dc6843fd85e4507f8ec2a1f378be4a (diff) | |
download | chromium_src-2e981ac35da47f84ee5a197e4a54a9f69a3b825d.zip chromium_src-2e981ac35da47f84ee5a197e4a54a9f69a3b825d.tar.gz chromium_src-2e981ac35da47f84ee5a197e4a54a9f69a3b825d.tar.bz2 |
- Update README.chromium to mention change to swig libs in third_party
- Provide platform-specific macros to swig.
- Update DEPS to use right swig updates
To be committed _after_ accompanying CL: http://codereview.chromium.org/661334
BUG=32285
TEST=None
Review URL: http://codereview.chromium.org/661342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41048 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test')
-rw-r--r-- | chrome/test/pyautolib/pyautolib.cc | 6 | ||||
-rw-r--r-- | chrome/test/pyautolib/pyautolib.h | 2 | ||||
-rw-r--r-- | chrome/test/pyautolib/pyautolib.i | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/chrome/test/pyautolib/pyautolib.cc b/chrome/test/pyautolib/pyautolib.cc index 9f0dd41..5ebfe0f 100644 --- a/chrome/test/pyautolib/pyautolib.cc +++ b/chrome/test/pyautolib/pyautolib.cc @@ -98,14 +98,14 @@ bool PyUITestSuite::IsFindInPageVisible(int window_index) { return is_visible; } -std::string PyUITestSuite::GetDownloadDirectory() { +FilePath PyUITestSuite::GetDownloadDirectory() { FilePath download_dir; scoped_refptr<TabProxy> tab_proxy(GetActiveTab()); EXPECT_TRUE(tab_proxy.get()); if (!tab_proxy.get()) - return download_dir.value(); + return download_dir; EXPECT_TRUE(tab_proxy->GetDownloadDirectory(&download_dir)); - return download_dir.value(); + return download_dir; } bool PyUITestSuite::OpenNewBrowserWindow(bool show) { diff --git a/chrome/test/pyautolib/pyautolib.h b/chrome/test/pyautolib/pyautolib.h index b6bb8c3..aab4dce 100644 --- a/chrome/test/pyautolib/pyautolib.h +++ b/chrome/test/pyautolib/pyautolib.h @@ -72,7 +72,7 @@ class PyUITestSuite : public UITestSuite, public UITestBase { bool IsFindInPageVisible(int window_index = 0); // Get the path to the downloads directory - std::string GetDownloadDirectory(); + FilePath GetDownloadDirectory(); // AutomationProxy methods diff --git a/chrome/test/pyautolib/pyautolib.i b/chrome/test/pyautolib/pyautolib.i index f745fbb..28aa983 100644 --- a/chrome/test/pyautolib/pyautolib.i +++ b/chrome/test/pyautolib/pyautolib.i @@ -69,7 +69,7 @@ class FilePath { typedef std::wstring StringType; #else typedef std::string StringType; -#endif // OS_WIN +#endif // SWIGWIN const StringType& value() const; %feature("docstring", "Construct an empty FilePath or from a string.") FilePath; @@ -110,7 +110,7 @@ class PyUITestSuite { // Get/fetch properties %feature("docstring", "Get the path to download directory.") GetDownloadDirectory; - std::string GetDownloadDirectory(); + FilePath GetDownloadDirectory(); %feature("docstring", "Get the path to profile directory.") user_data_dir; FilePath user_data_dir() const; |