diff options
| author | rsesek@chromium.org <rsesek@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-26 22:47:11 +0000 |
|---|---|---|
| committer | rsesek@chromium.org <rsesek@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-26 22:47:11 +0000 |
| commit | 828cabe21191c14e43fc3dda06918f7ec8c91988 (patch) | |
| tree | 5d6872acf00deee9aa71392a427d60e25e09cbeb /chrome/test | |
| parent | 178102d66e9dc222613e36bfac6933d3e5de59a9 (diff) | |
| download | chromium_src-828cabe21191c14e43fc3dda06918f7ec8c91988.zip chromium_src-828cabe21191c14e43fc3dda06918f7ec8c91988.tar.gz chromium_src-828cabe21191c14e43fc3dda06918f7ec8c91988.tar.bz2 | |
Update the TabContents::SavePage parameter to take FilePath instead of wstring to avoid conversions "To and From wstring".
BUG=None
TEST=run unit_tests.exe
Review URL: http://codereview.chromium.org/217008
Patch from tfarina.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27331 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test')
| -rw-r--r-- | chrome/test/automation/automation_messages_internal.h | 4 | ||||
| -rw-r--r-- | chrome/test/automation/tab_proxy.cc | 4 | ||||
| -rw-r--r-- | chrome/test/automation/tab_proxy.h | 3 |
3 files changed, 5 insertions, 6 deletions
diff --git a/chrome/test/automation/automation_messages_internal.h b/chrome/test/automation/automation_messages_internal.h index 1e87cfa..e7016cf 100644 --- a/chrome/test/automation/automation_messages_internal.h +++ b/chrome/test/automation/automation_messages_internal.h @@ -658,8 +658,8 @@ IPC_BEGIN_MESSAGES(Automation) // for saving resources. The fourth parameter is the saving type: 0 for HTML // only; 1 for complete web page. // The return value contains a bool which is true on success. - IPC_SYNC_MESSAGE_ROUTED4_1(AutomationMsg_SavePage, int, std::wstring, - std::wstring, int, bool) + IPC_SYNC_MESSAGE_ROUTED4_1(AutomationMsg_SavePage, int, FilePath, FilePath, + int, bool) // This message requests the text currently being displayed in the // AutocompleteEdit. The parameter is the handle to the AutocompleteEdit. diff --git a/chrome/test/automation/tab_proxy.cc b/chrome/test/automation/tab_proxy.cc index 6ab222a..eb00d74 100644 --- a/chrome/test/automation/tab_proxy.cc +++ b/chrome/test/automation/tab_proxy.cc @@ -576,8 +576,8 @@ bool TabProxy::PrintAsync() { return sender_->Send(new AutomationMsg_PrintAsync(0, handle_)); } -bool TabProxy::SavePage(const std::wstring& file_name, - const std::wstring& dir_path, +bool TabProxy::SavePage(const FilePath& file_name, + const FilePath& dir_path, SavePackage::SavePackageType type) { if (!is_valid()) return false; diff --git a/chrome/test/automation/tab_proxy.h b/chrome/test/automation/tab_proxy.h index 7f56932..94bf717 100644 --- a/chrome/test/automation/tab_proxy.h +++ b/chrome/test/automation/tab_proxy.h @@ -272,8 +272,7 @@ class TabProxy : public AutomationResourceProxy { // Save the current web page. |file_name| is the HTML file name, and // |dir_path| is the directory for saving resource files. |type| indicates // which type we're saving as: HTML only or the complete web page. - bool SavePage(const std::wstring& file_name, - const std::wstring& dir_path, + bool SavePage(const FilePath& file_name, const FilePath& dir_path, SavePackage::SavePackageType type); // Posts a message to the external tab. |