diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-13 19:56:17 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-13 19:56:17 +0000 |
commit | 11f48572859aca238afeb436d2504c5ffab49f07 (patch) | |
tree | 1b31af349eb99a9e83716f5add3273b42bee41cf /chrome/test | |
parent | af530ac147feb1b04446f529daa4cc4448f89b23 (diff) | |
download | chromium_src-11f48572859aca238afeb436d2504c5ffab49f07.zip chromium_src-11f48572859aca238afeb436d2504c5ffab49f07.tar.gz chromium_src-11f48572859aca238afeb436d2504c5ffab49f07.tar.bz2 |
Fixes almost all of the rest of lint errors in the chrome/ directory (minus the really hard ones which will need actual review instead of rubber-stamping.)
Review URL: http://codereview.chromium.org/386026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test')
11 files changed, 22 insertions, 22 deletions
diff --git a/chrome/test/automation/autocomplete_edit_proxy.h b/chrome/test/automation/autocomplete_edit_proxy.h index b0594d8..abbe849 100644 --- a/chrome/test/automation/autocomplete_edit_proxy.h +++ b/chrome/test/automation/autocomplete_edit_proxy.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_TEST_AUTOMATION_AUTOCOMPLETE_EDIT_PROXY_H__ -#define CHROME_TEST_AUTOMATION_AUTOCOMPLETE_EDIT_PROXY_H__ +#ifndef CHROME_TEST_AUTOMATION_AUTOCOMPLETE_EDIT_PROXY_H_ +#define CHROME_TEST_AUTOMATION_AUTOCOMPLETE_EDIT_PROXY_H_ #include <string> #include <vector> @@ -149,4 +149,4 @@ class AutocompleteEditProxy : public AutomationResourceProxy { DISALLOW_EVIL_CONSTRUCTORS(AutocompleteEditProxy); }; -#endif // #define CHROME_TEST_AUTOMATION_AUTOCOMPLETE_EDIT_PROXY_H__ +#endif // CHROME_TEST_AUTOMATION_AUTOCOMPLETE_EDIT_PROXY_H_ diff --git a/chrome/test/automation/automation_handle_tracker.h b/chrome/test/automation/automation_handle_tracker.h index 12a5920..1db6015 100644 --- a/chrome/test/automation/automation_handle_tracker.h +++ b/chrome/test/automation/automation_handle_tracker.h @@ -74,7 +74,7 @@ class AutomationResourceProxy // discard the handle. class AutomationHandleTracker { public: - AutomationHandleTracker(AutomationMessageSender* sender) + explicit AutomationHandleTracker(AutomationMessageSender* sender) : sender_(sender) {} ~AutomationHandleTracker(); diff --git a/chrome/test/chrome_plugin/test_chrome_plugin.cc b/chrome/test/chrome_plugin/test_chrome_plugin.cc index 50672d0..751a9c2 100644 --- a/chrome/test/chrome_plugin/test_chrome_plugin.cc +++ b/chrome/test/chrome_plugin/test_chrome_plugin.cc @@ -46,7 +46,7 @@ void STDCALL InvokeLaterCallback(void* data) { // ResponseStream: Manages the streaming of the payload data. class ResponseStream : public base::RefCounted<ResponseStream> { -public: + public: ResponseStream(const TestResponsePayload* payload, CPRequest* request); void Init(); @@ -227,13 +227,13 @@ int STDCALL CPR_Read(CPRequest* request, void* buf, uint32 buf_size) { // RequestResponse: manages the retrieval of response data from the host class RequestResponse { -public: + public: explicit RequestResponse(const std::string& raw_headers) : raw_headers_(raw_headers), offset_(0) {} void StartReading(CPRequest* request); void ReadCompleted(CPRequest* request, int bytes_read); -private: + private: std::string raw_headers_; std::string body_; int offset_; diff --git a/chrome/test/live_sync/live_bookmarks_sync_test.h b/chrome/test/live_sync/live_bookmarks_sync_test.h index c9d4486..1ff0251 100644 --- a/chrome/test/live_sync/live_bookmarks_sync_test.h +++ b/chrome/test/live_sync/live_bookmarks_sync_test.h @@ -78,4 +78,4 @@ class LiveBookmarksSyncTest : public InProcessBrowserTest { DISALLOW_COPY_AND_ASSIGN(LiveBookmarksSyncTest); }; -#endif // CHROME_TEST_SYNC_LIVE_BOOKMARKS_SYNC_TEST_H_ +#endif // CHROME_TEST_LIVE_SYNC_LIVE_BOOKMARKS_SYNC_TEST_H_ diff --git a/chrome/test/live_sync/profile_sync_service_test_harness.h b/chrome/test/live_sync/profile_sync_service_test_harness.h index f242be3..8877c70 100644 --- a/chrome/test/live_sync/profile_sync_service_test_harness.h +++ b/chrome/test/live_sync/profile_sync_service_test_harness.h @@ -105,4 +105,4 @@ class ProfileSyncServiceTestHarness : public ProfileSyncServiceObserver { DISALLOW_COPY_AND_ASSIGN(ProfileSyncServiceTestHarness); }; -#endif // CHROME_TEST_SYNC_PROFILE_SYNC_SERVICE_TEST_HARNESS_H_ +#endif // CHROME_TEST_LIVE_SYNC_PROFILE_SYNC_SERVICE_TEST_HARNESS_H_ diff --git a/chrome/test/mini_installer_test/mini_installer_test_constants.cc b/chrome/test/mini_installer_test/mini_installer_test_constants.cc index cbb4533..c26b990 100644 --- a/chrome/test/mini_installer_test/mini_installer_test_constants.cc +++ b/chrome/test/mini_installer_test/mini_installer_test_constants.cc @@ -50,7 +50,8 @@ const wchar_t kFullInstall[] = L"Full"; const wchar_t kChromeMetaInstallerExe[] = L"\\\\172.23.44.61\\shared\\chrome_autotest\\beta_build\\ChromeSetup.exe"; const wchar_t kChromeStandAloneInstallerLocation[] = - L"\\\\172.24.6.7\\shares\\googleclient\\nightly\\builds\\Win-OmahaInstallers\\latest\\opt-win\\staging\\"; + L"\\\\172.24.6.7\\shares\\googleclient\\nightly\\builds\\" + L"Win-OmahaInstallers\\latest\\opt-win\\staging\\"; const wchar_t kChromeApplyTagExe[] = L"\\\\172.23.44.61\\shared\\chrome_autotest\\ApplyTag.exe"; const wchar_t kChromeApplyTagParameters[] = diff --git a/chrome/test/reliability/page_load_test.h b/chrome/test/reliability/page_load_test.h index b369ead..12c26d1 100644 --- a/chrome/test/reliability/page_load_test.h +++ b/chrome/test/reliability/page_load_test.h @@ -13,4 +13,4 @@ // Parse the command line options and set the page range accordingly. void SetPageRange(const CommandLine&); -#endif // CHROME_TEST_RELIABILITY_PAGE_LOAD_TEST_H_ +#endif // CHROME_TEST_RELIABILITY_PAGE_LOAD_TEST_H_ diff --git a/chrome/test/reliability/reliability_test_suite.h b/chrome/test/reliability/reliability_test_suite.h index 0bd1bc2..a161d8a 100644 --- a/chrome/test/reliability/reliability_test_suite.h +++ b/chrome/test/reliability/reliability_test_suite.h @@ -9,12 +9,11 @@ #include "chrome/test/ui/ui_test_suite.h" class ReliabilityTestSuite : public UITestSuite { -public: + public: ReliabilityTestSuite(int argc, char** argv) : UITestSuite(argc, argv) { } -protected: - + protected: virtual void Initialize() { UITestSuite::Initialize(); @@ -22,4 +21,4 @@ protected: } }; -#endif // CHROME_TEST_RELIABILITY_RELIABILITY_TEST_SUITE_H_ +#endif // CHROME_TEST_RELIABILITY_RELIABILITY_TEST_SUITE_H_ diff --git a/chrome/test/sync/engine/test_directory_setter_upper.h b/chrome/test/sync/engine/test_directory_setter_upper.h index aefca40..95cb13d 100644 --- a/chrome/test/sync/engine/test_directory_setter_upper.h +++ b/chrome/test/sync/engine/test_directory_setter_upper.h @@ -93,7 +93,7 @@ class TriggeredOpenTestDirectorySetterUpper : public TestDirectorySetterUpper { // A triggered open is typically in response to a successful auth event just // as in "real life". In this case, the name that will be used should be // deterministically known at construction, and is passed in |name|. - TriggeredOpenTestDirectorySetterUpper(const std::string& name); + explicit TriggeredOpenTestDirectorySetterUpper(const std::string& name); virtual void SetUp(); virtual void TearDown(); }; diff --git a/chrome/test/test_launcher/test_runner.h b/chrome/test/test_launcher/test_runner.h index 6700dde..9c743f8 100644 --- a/chrome/test/test_launcher/test_runner.h +++ b/chrome/test/test_launcher/test_runner.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_TEST_TEST_LAUNCHER_TEST_RUNNER_ -#define CHROME_TEST_TEST_LAUNCHER_TEST_RUNNER_ +#ifndef CHROME_TEST_TEST_LAUNCHER_TEST_RUNNER_H_ +#define CHROME_TEST_TEST_LAUNCHER_TEST_RUNNER_H_ #include <string> #include <vector> @@ -49,4 +49,4 @@ class TestRunnerFactory { } // namespace -#endif // CHROME_TEST_TEST_LAUNCHER_TEST_RUNNER_ +#endif // CHROME_TEST_TEST_LAUNCHER_TEST_RUNNER_H_ diff --git a/chrome/test/test_notification_tracker.h b/chrome/test/test_notification_tracker.h index fbc2392..2307b4b 100644 --- a/chrome/test/test_notification_tracker.h +++ b/chrome/test/test_notification_tracker.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_TEST_NOTIFICATION_TRACKER_H_ -#define CHROME_TEST_NOTIFICATION_TRACKER_H_ +#ifndef CHROME_TEST_TEST_NOTIFICATION_TRACKER_H_ +#define CHROME_TEST_TEST_NOTIFICATION_TRACKER_H_ #include <vector> @@ -76,4 +76,4 @@ class TestNotificationTracker : public NotificationObserver { DISALLOW_COPY_AND_ASSIGN(TestNotificationTracker); }; -#endif // CHROME_TEST_NOTIFICATION_TRACKER_H_ +#endif // CHROME_TEST_TEST_NOTIFICATION_TRACKER_H_ |