diff options
| author | sgk@google.com <sgk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-21 00:05:20 +0000 |
|---|---|---|
| committer | sgk@google.com <sgk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-21 00:05:20 +0000 |
| commit | c8e4a32467a32e2499f39d9f323b42f05266f796 (patch) | |
| tree | 99c4347ba2ac54efc3d9f15bee397c8ce2685309 /chrome/test | |
| parent | a710ad60ce70dafd00bb7a140cb9ee2d5be87acb (diff) | |
| download | chromium_src-c8e4a32467a32e2499f39d9f323b42f05266f796.zip chromium_src-c8e4a32467a32e2499f39d9f323b42f05266f796.tar.gz chromium_src-c8e4a32467a32e2499f39d9f323b42f05266f796.tar.bz2 | |
Make the commit_charge the important statistic (displayed on the
perf overview dashboard) for memory_test, but not for page_cycler.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/418034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32714 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test')
| -rw-r--r-- | chrome/test/memory_test/memory_test.cc | 3 | ||||
| -rw-r--r-- | chrome/test/page_cycler/page_cycler_test.cc | 6 | ||||
| -rw-r--r-- | chrome/test/ui/ui_test.cc | 7 | ||||
| -rw-r--r-- | chrome/test/ui/ui_test.h | 4 |
4 files changed, 13 insertions, 7 deletions
diff --git a/chrome/test/memory_test/memory_test.cc b/chrome/test/memory_test/memory_test.cc index f572406..5284bb8 100644 --- a/chrome/test/memory_test/memory_test.cc +++ b/chrome/test/memory_test/memory_test.cc @@ -227,7 +227,8 @@ class MemoryTest : public UITest { size_t stop_size = base::GetSystemCommitCharge(); PrintIOPerfInfo(test_name, user_data_dir_); PrintMemoryUsageInfo(test_name, user_data_dir_); - PrintSystemCommitCharge(test_name, stop_size - start_size); + PrintSystemCommitCharge(test_name, stop_size - start_size, + true /* important */); } private: diff --git a/chrome/test/page_cycler/page_cycler_test.cc b/chrome/test/page_cycler/page_cycler_test.cc index 234b021..40e5372 100644 --- a/chrome/test/page_cycler/page_cycler_test.cc +++ b/chrome/test/page_cycler/page_cycler_test.cc @@ -244,7 +244,8 @@ class PageCyclerTest : public UITest { PrintMemoryUsageInfo(suffix, data_dir); PrintIOPerfInfo(suffix, data_dir); - PrintSystemCommitCharge(suffix, stop_size - start_size); + PrintSystemCommitCharge(suffix, stop_size - start_size, + false /* not important */); std::string trace_name = "t" + std::string(suffix); wprintf(L"\nPages: [%ls]\n", pages.c_str()); @@ -294,7 +295,8 @@ class PageCyclerReferenceTest : public PageCyclerTest { PrintMemoryUsageInfo("_ref", data_dir); PrintIOPerfInfo("_ref", data_dir); - PrintSystemCommitCharge("_ref", stop_size - start_size); + PrintSystemCommitCharge("_ref", stop_size - start_size, + false /* not important */); PrintResultList("times", "", "t_ref", timings, "ms", true /* important */); diff --git a/chrome/test/ui/ui_test.cc b/chrome/test/ui/ui_test.cc index 893ad9a..b243140 100644 --- a/chrome/test/ui/ui_test.cc +++ b/chrome/test/ui/ui_test.cc @@ -1419,8 +1419,9 @@ void UITest::PrintMemoryUsageInfo(const char* test_name, FilePath data_dir) { false /* not important */); } -void UITest::PrintSystemCommitCharge(const char* test_name, size_t charge) { +void UITest::PrintSystemCommitCharge(const char* test_name, + size_t charge, + bool important) { std::string trace_name(test_name); - PrintResult("commit_charge", "", "cc" + trace_name, charge, "kb", - false /* important */); + PrintResult("commit_charge", "", "cc" + trace_name, charge, "kb", important); } diff --git a/chrome/test/ui/ui_test.h b/chrome/test/ui/ui_test.h index 81db9e1..22de5c3 100644 --- a/chrome/test/ui/ui_test.h +++ b/chrome/test/ui/ui_test.h @@ -459,7 +459,9 @@ class UITest : public testing::Test { void PrintMemoryUsageInfo(const char* test_name, FilePath data_dir); // Prints memory commit charge stats for use by perf graphs. - void PrintSystemCommitCharge(const char* test_name, size_t charge); + void PrintSystemCommitCharge(const char* test_name, + size_t charge, + bool important); private: // Check that no processes related to Chrome exist, displaying |