diff options
author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-09 21:46:15 +0000 |
---|---|---|
committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-09 21:46:15 +0000 |
commit | 3683cbb58a3e46cc3bb3860268e7bcf6ca499a0b (patch) | |
tree | c72557a7a4f3f24328757dd3c658b58865b57c0c /chrome/test | |
parent | b3d7a18cfceb5305aa563a321408665e4d7d3d12 (diff) | |
download | chromium_src-3683cbb58a3e46cc3bb3860268e7bcf6ca499a0b.zip chromium_src-3683cbb58a3e46cc3bb3860268e7bcf6ca499a0b.tar.gz chromium_src-3683cbb58a3e46cc3bb3860268e7bcf6ca499a0b.tar.bz2 |
UI test portage, second try.
first try here: <http://codereview.chromium.org/63149>
Review URL: http://codereview.chromium.org/67006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13464 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test')
-rw-r--r-- | chrome/test/automation/automation_messages_internal.h | 2 | ||||
-rw-r--r-- | chrome/test/automation/automation_proxy.cc | 4 | ||||
-rw-r--r-- | chrome/test/automation/automation_proxy.h | 6 |
3 files changed, 6 insertions, 6 deletions
diff --git a/chrome/test/automation/automation_messages_internal.h b/chrome/test/automation/automation_messages_internal.h index 59599b1..b954b3f 100644 --- a/chrome/test/automation/automation_messages_internal.h +++ b/chrome/test/automation/automation_messages_internal.h @@ -360,7 +360,7 @@ IPC_BEGIN_MESSAGES(Automation) // Opens a new browser window. IPC_SYNC_MESSAGE_ROUTED1_0(AutomationMsg_OpenNewBrowserWindow, - int /* show_command*/ ) + bool /* show */ ) // This message requests the handle (int64 app-unique identifier) of the // current active top window. On error, the returned handle value is 0. diff --git a/chrome/test/automation/automation_proxy.cc b/chrome/test/automation/automation_proxy.cc index 3a8f406..416d0c9 100644 --- a/chrome/test/automation/automation_proxy.cc +++ b/chrome/test/automation/automation_proxy.cc @@ -466,8 +466,8 @@ void AutomationProxy::InvalidateHandle(const IPC::Message& message) { } } -bool AutomationProxy::OpenNewBrowserWindow(int show_command) { - return Send(new AutomationMsg_OpenNewBrowserWindow(0, show_command)); +bool AutomationProxy::OpenNewBrowserWindow(bool show) { + return Send(new AutomationMsg_OpenNewBrowserWindow(0, show)); } #if defined(OS_WIN) diff --git a/chrome/test/automation/automation_proxy.h b/chrome/test/automation/automation_proxy.h index 138edd0..46a3b23 100644 --- a/chrome/test/automation/automation_proxy.h +++ b/chrome/test/automation/automation_proxy.h @@ -80,10 +80,10 @@ class AutomationProxy : public IPC::Channel::Listener, // Returns true if the load is successful. bool WaitForInitialNewTabUILoad(int* load_time); - // Open a new browser window, returning true on success. |show_command| - // identifies how the window should be shown. + // Open a new browser window, returning true on success. |show| + // identifies whether the window should be shown. // False likely indicates an IPC error. - bool OpenNewBrowserWindow(int show_command); + bool OpenNewBrowserWindow(bool show); // Fills the number of open browser windows into the given variable, returning // true on success. False likely indicates an IPC error. |