diff options
author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-29 21:34:01 +0000 |
---|---|---|
committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-29 21:34:01 +0000 |
commit | 5d980ff35a7aa854c4861cf10acc73208acfcf79 (patch) | |
tree | 01d7d66f56f06ad6b54239e8405fb773452189a0 /chrome/test | |
parent | 5557e50244c7a963e93256293984fe3baea65dfd (diff) | |
download | chromium_src-5d980ff35a7aa854c4861cf10acc73208acfcf79.zip chromium_src-5d980ff35a7aa854c4861cf10acc73208acfcf79.tar.gz chromium_src-5d980ff35a7aa854c4861cf10acc73208acfcf79.tar.bz2 |
A little more polish on the RSS extension.
- Fix previewing of sites the contain html in the title. Example feed:
http://code.google.com/feeds/p/chromium/updates/basic
- The [ Feed ] link now links to the view-source, killing three birds
with one stone (gives people access to raw feed, doesn't open the
same feed again in a new tab and shows the feed url in the address
bar so people don't have to right-click the link).
- Make sure the title links we create don't show inline in the iframe
by setting the target to _top.
BUG=None
TEST=None (already has feed parsing tests).
Review URL: http://codereview.chromium.org/551201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37537 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test')
3 files changed, 5 insertions, 4 deletions
diff --git a/chrome/test/data/extensions/subscribe_page_action/iframe.js b/chrome/test/data/extensions/subscribe_page_action/iframe.js index e254fb58..aa64d6c 100644 --- a/chrome/test/data/extensions/subscribe_page_action/iframe.js +++ b/chrome/test/data/extensions/subscribe_page_action/iframe.js @@ -13,7 +13,7 @@ var maxFeedItems = 10; /* The maximum number of characters to show in the feed item title. */ -var maxTitleCount = 64; +var maxTitleCount = 1024; window.addEventListener("message", function(e) { var parser = new DOMParser(); @@ -87,7 +87,8 @@ function buildPreview(doc) { anchor.id = "anchor_" + String(i); if (link != "") anchor.href = link; - anchor.appendChild(document.createTextNode(itemTitle)); + anchor.innerHTML = itemTitle; + anchor.target = "_top"; anchor.className = "item_title"; var span = document.createElement("span"); diff --git a/chrome/test/data/extensions/subscribe_page_action/manifest.json b/chrome/test/data/extensions/subscribe_page_action/manifest.json index ae87991..13ddfb5 100644 --- a/chrome/test/data/extensions/subscribe_page_action/manifest.json +++ b/chrome/test/data/extensions/subscribe_page_action/manifest.json @@ -20,5 +20,5 @@ "popup": "popup.html" }, "permissions": [ "tabs", "http://*/*", "https://*/*" ], - "version": "2.0.2" + "version": "2.0.3" } diff --git a/chrome/test/data/extensions/subscribe_page_action/subscribe.js b/chrome/test/data/extensions/subscribe_page_action/subscribe.js index 6234dfa..cf145be 100644 --- a/chrome/test/data/extensions/subscribe_page_action/subscribe.js +++ b/chrome/test/data/extensions/subscribe_page_action/subscribe.js @@ -114,7 +114,7 @@ function main() { req.open("GET", feedUrl, !synchronousRequest); req.send(null); - document.getElementById('feedUrl').href = feedUrl; + document.getElementById('feedUrl').href = 'view-source:' + feedUrl; } // Sets the title for the feed. |