diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-17 21:21:41 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-17 21:21:41 +0000 |
| commit | 76ac017bca97c5e45569c43c4aded1e287e2cb0b (patch) | |
| tree | 1f4d5b936632414df9253da28df085a0edd2b85b /chrome/test | |
| parent | 4038e6e270171286189b2cd54fcb45a7e9c08222 (diff) | |
| download | chromium_src-76ac017bca97c5e45569c43c4aded1e287e2cb0b.zip chromium_src-76ac017bca97c5e45569c43c4aded1e287e2cb0b.tar.gz chromium_src-76ac017bca97c5e45569c43c4aded1e287e2cb0b.tar.bz2 | |
There were a number of new crashes in reliability test runs in flash after revision 34593. The crash occured
while dereferencing an invalid g_current_plugin_instance global which points to the last plugin instance we
yield control to. We maintain a local global stack for this variable which ensures that it gets set and
reset correctly in nested invocations. Turns out that this broke in a recent change which caused the global
to not get reset at times, thus leading to a crash when it was dereferenced.
I also changed the code which maintains the local global stack in NativeWndProc to only do this before we invoke
the plugin wndproc via CallWindowProc. The other cases like ThrottleMessage don't need to do this as they don't
yield control to the plugin.
Fixes http://code.google.com/p/chromium/issues/detail?id=30607
Bug=30607
Review URL: http://codereview.chromium.org/503037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34875 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test')
| -rw-r--r-- | chrome/test/data/reliability/known_crashes.txt | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/test/data/reliability/known_crashes.txt b/chrome/test/data/reliability/known_crashes.txt index aa6b9c3..156f365 100644 --- a/chrome/test/data/reliability/known_crashes.txt +++ b/chrome/test/data/reliability/known_crashes.txt @@ -149,9 +149,6 @@ PREFIX : malloc___webplugindelegateimpl::flashwindowlesswndproc___npapi::plugini # 29759 PREFIX : webcore::imageeventsender::dispatchpendingevents -# 30607 -SUBSTRING : _invalid_parameter_noinfo___std::vector<char,std::allocator<char> >::clear___WebCursor::InitFromCursorInfo___WebCursor::InitFromExternalCursor - # 30681 PREFIX : std::basic_string<char,std::char_traits<char>,std::allocator<char> >::assign___cldhelper::language___tabcontents::observe___notificationservice::notify___cldhelper::detectiondone___messageloop::runtask___messageloop::dowork___base::messagepumpforui::dorunloop___base::messagepumpwin::runwithdispatcher___messageloop::runinternal___messageloopforui::run___`anonymous namespace'::runuimessageloop___browsermain___chromemain___maindllloader::launch___wwinmain_____tmaincrtstartup |